summaryrefslogtreecommitdiff
path: root/src/soc/intel/skylake
diff options
context:
space:
mode:
authorMichael Niewöhner <foss@mniewoehner.de>2019-10-21 18:58:04 +0200
committerNico Huber <nico.h@gmx.de>2019-10-26 15:48:47 +0000
commit40f893e9f3a14c85560ab3115ae9f56a1ee52323 (patch)
treeb2fd3e12baa573e86c441e4539ff2db58e97daf8 /src/soc/intel/skylake
parentb17f3d3d3cdd215edcff492699c744a4c85908d0 (diff)
downloadcoreboot-40f893e9f3a14c85560ab3115ae9f56a1ee52323.tar.xz
soc/intel: common,skl,cnl,icl: drop reserved mmio memory size calculation
Remove the calculation of the Reserved Intel MMIO Memory size from systemagent and memmap, since it is not needed. The size is used in SA to calculate the space between cbmem_top and TSEG without DPR and Chipset Reserved Memory. Since this will always be equal to 0, the reservation will be skipped and TSEG, DPR and Chipset Reserved Memory will get reserved alltogether. By reading the code and pratical testing we figured out that: - TSEG - DPR - reserved - top_of_memory == 0 - TSEG - DPR - reserved == top_of_memory This means the whole block will never reserve anything because it is always 0. Hence the code can be removed for simplification. Tested successfully on X11SSM-F Change-Id: I0cc730551eb3a79c78a971b40056de8d029f4b82 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36216 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/skylake')
-rw-r--r--src/soc/intel/skylake/memmap.c15
1 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c
index f2790efb35..780c73c298 100644
--- a/src/soc/intel/skylake/memmap.c
+++ b/src/soc/intel/skylake/memmap.c
@@ -212,21 +212,6 @@ static uintptr_t calculate_dram_base(size_t *reserved_mem_size)
return dram_base;
}
-/*
- * SoC implementation
- *
- * SoC call to summarize all Intel Reserve MMIO size and report to SA
- */
-size_t soc_reserved_mmio_size(void)
-{
- struct ebda_config cfg;
-
- retrieve_ebda_object(&cfg);
-
- /* Get Intel Reserved Memory Range Size */
- return cfg.reserved_mem_size;
-}
-
/* Fill up memory layout information */
void fill_soc_memmap_ebda(struct ebda_config *cfg)
{