summaryrefslogtreecommitdiff
path: root/src/soc/intel/xeon_sp/skx/soc_util.c
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2020-11-06 12:15:41 +0100
committerArthur Heymans <arthur@aheymans.xyz>2020-11-13 19:27:16 +0000
commit165893b67be4a116a96b242bf4ee5370ec707b43 (patch)
tree3ddd050a10296c3f13649725f030710910b104a9 /src/soc/intel/xeon_sp/skx/soc_util.c
parent89e83b76b4d50d0977345becf504a1afa0668211 (diff)
downloadcoreboot-165893b67be4a116a96b242bf4ee5370ec707b43.tar.xz
soc/intel/xeon_sp: Change the return type of get_iio_stack_info()
The somewhat unrelated return value makes the function harder to understand and the return type is not consistently used. Use a different helper function to get the HOB Pci64BitResourceAllocation data. Change-Id: I9a03cbb0ebbb48cc052d4c082d359c0087aaeb3e Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47298 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
Diffstat (limited to 'src/soc/intel/xeon_sp/skx/soc_util.c')
-rw-r--r--src/soc/intel/xeon_sp/skx/soc_util.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c
index af6dfcc341..d5e1ae13f4 100644
--- a/src/soc/intel/xeon_sp/skx/soc_util.c
+++ b/src/soc/intel/xeon_sp/skx/soc_util.c
@@ -55,7 +55,7 @@ const struct SystemMemoryMapHob *get_system_memory_map(void)
return memmap_addr;
}
-uint8_t get_iiostack_info(struct iiostack_resource *info)
+void get_iiostack_info(struct iiostack_resource *info)
{
const IIO_UDS *hob = get_iio_uds();
@@ -71,8 +71,6 @@ uint8_t get_iiostack_info(struct iiostack_resource *info)
memcpy(&info->res[info->no_of_stacks++], ri, sizeof(STACK_RES));
}
}
-
- return hob->PlatformData.Pci64BitResourceAllocation;
}
uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)