diff options
| author | Nico Huber <nico.h@gmx.de> | 2020-04-05 13:55:12 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-04-10 11:25:04 +0000 |
| commit | a461b694a6c0468cd679628aeebf83437027fb45 (patch) | |
| tree | 6ba4647074e37d7580ab85683c8aa40358246e4c /src/soc/intel/xeon_sp | |
| parent | 9734325f4568c19d1ffc392084aa431a810a0709 (diff) | |
| download | coreboot-a461b694a6c0468cd679628aeebf83437027fb45.tar.xz | |
Drop unnecessary DEVICE_NOOP entries
Providing an explicit no-op function pointer is only necessary for
`.read_resources` and `.set_resources`. All other device-operation
pointers are optional and can be NULL.
Change-Id: I3d139f7be86180558cabec04b8566873062e33be
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40206
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/xeon_sp')
| -rw-r--r-- | src/soc/intel/xeon_sp/cpx/chip.c | 1 | ||||
| -rw-r--r-- | src/soc/intel/xeon_sp/skx/chip.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c index ef18e45e9b..5f1dedf497 100644 --- a/src/soc/intel/xeon_sp/cpx/chip.c +++ b/src/soc/intel/xeon_sp/cpx/chip.c @@ -33,7 +33,6 @@ static struct device_operations pci_domain_ops = { static struct device_operations cpu_bus_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .init = cpx_init_cpus, }; diff --git a/src/soc/intel/xeon_sp/skx/chip.c b/src/soc/intel/xeon_sp/skx/chip.c index 90ae0252e2..fbd13d524c 100644 --- a/src/soc/intel/xeon_sp/skx/chip.c +++ b/src/soc/intel/xeon_sp/skx/chip.c @@ -484,7 +484,6 @@ static struct device_operations pci_domain_ops = { static struct device_operations cpu_bus_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .init = xeon_sp_init_cpus, #if CONFIG(HAVE_ACPI_TABLES) /* defined in src/soc/intel/common/block/acpi/acpi.c */ |