diff options
| author | Furquan Shaikh <furquan@google.com> | 2016-08-14 21:59:03 -0700 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2016-08-15 19:49:43 +0200 |
| commit | 5ff952259ad631e24b4cb1573fe2f6c99d879e7a (patch) | |
| tree | a6d8a1517039d2086df27c16f7cfe5bc3e79a108 /src/soc/intel | |
| parent | 363526cfb8b4234384270d7882be2e9ead424c07 (diff) | |
| download | coreboot-5ff952259ad631e24b4cb1573fe2f6c99d879e7a.tar.xz | |
intel/quark: Fix assert check
Having an assignment in assert does not make sense. This seems like it
was intended to check if chip is always same as segments->chip.
Change-Id: I297d9e76a0404a1f510d43f8b9c39e96b557689f
Reported-by: Coverity ID 1357439
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/16219
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Lee Leahy <leroy.p.leahy@intel.com>
Diffstat (limited to 'src/soc/intel')
| -rw-r--r-- | src/soc/intel/quark/i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c index 6465b66040..6b1f6dd46c 100644 --- a/src/soc/intel/quark/i2c.c +++ b/src/soc/intel/quark/i2c.c @@ -101,7 +101,7 @@ int platform_i2c_transfer(unsigned bus, struct i2c_seg *segments, int count) length = segments->len; ASSERT (buffer != NULL); ASSERT (length >= 1); - ASSERT (segments->chip = chip); + ASSERT (segments->chip == chip); if (segments->read) { /* Place read commands into the FIFO */ |