diff options
author | Furquan Shaikh <furquan@google.com> | 2018-05-02 23:29:04 -0700 |
---|---|---|
committer | Furquan Shaikh <furquan@google.com> | 2018-05-04 01:15:52 +0000 |
commit | c0257dd7ae9c8899b49c05ef74d9c5a91ee71d4f (patch) | |
tree | 1654b7ec1711748e63532b618ea73f9fc5233660 /src/soc/intel | |
parent | f658edf434421a2cb475c753c08e6d92e2be58c1 (diff) | |
download | coreboot-c0257dd7ae9c8899b49c05ef74d9c5a91ee71d4f.tar.xz |
ifdtool: Add a list of known platforms that support IFD_VERSION_2
ifdtool has relied on one of the fields within FCBA(read_freq) to
determine whether a platform supports IFD_VERSION_1 or
IFD_VERSION_2. However, newer platforms like GLK and CNL do not have
read_freq field in FCBA and so the value of these bits cannot be used
as an indicator to distinguish IFD versions. In the long run, we need
to re-write ifdtool to have a better mapping of SoC to IFD fields. But
until that is done, this change adds a list of platforms that we know
do not support read_freq field but still use IFD_VERSION_2. This
change also updates GLK and CNL to pass in platform parameter to
ifdtool.
BUG=b:79109029, b:69270831
Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/26023
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel')
-rw-r--r-- | src/soc/intel/apollolake/Kconfig | 1 | ||||
-rw-r--r-- | src/soc/intel/cannonlake/Kconfig | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 8cac151640..0f1f12152b 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -350,6 +350,7 @@ config SMM_RESERVED_SIZE config IFD_CHIPSET string + default "glk" if SOC_INTEL_GLK default "aplk" config CPU_BCLK_MHZ diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 541e5165af..898b4444d7 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -114,6 +114,10 @@ config DCACHE_BSP_STACK_SIZE The amount of anticipated stack usage in CAR by bootblock and other stages. +config IFD_CHIPSET + string + default "cnl" + config IED_REGION_SIZE hex default 0x400000 |