summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2020-03-23 01:33:23 +0100
committerNico Huber <nico.h@gmx.de>2020-03-24 20:36:01 +0000
commite47132be6601bfd485076d6520e56a8b8ecb0737 (patch)
treef21f1e778f9886b2f633ab9916d37a3661caefb0 /src/soc/intel
parent53ec8c5722cc50ff9e48a8ff6c6b4011326659de (diff)
downloadcoreboot-e47132be6601bfd485076d6520e56a8b8ecb0737.tar.xz
intel/broadwell: Correct backlight-PWM divider
The PWM-granularity chicken bit in the Wildcat Point and Lynx Point PCHs has actually the opposite meaning of the one for Sunrise Point and later. When the bit is set, we get a divider of 16, when it's unset 128. Flip the bit! Change-Id: I1dbde1915d8b269c11643a1636565a560eb07334 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39770 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/broadwell/igd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/broadwell/igd.c b/src/soc/intel/broadwell/igd.c
index 37f3871483..ecb5417181 100644
--- a/src/soc/intel/broadwell/igd.c
+++ b/src/soc/intel/broadwell/igd.c
@@ -348,10 +348,10 @@ static void igd_setup_panel(struct device *dev)
south_chicken2 = gtt_read(SOUTH_CHICKEN2);
if (conf->gpu_pch_backlight_pwm_hz > hz_limit) {
pwm_increment = 16;
- south_chicken2 &= ~(1 << 5);
+ south_chicken2 |= 1 << 5;
} else {
pwm_increment = 128;
- south_chicken2 |= 1 << 5;
+ south_chicken2 &= ~(1 << 5);
}
gtt_write(SOUTH_CHICKEN2, south_chicken2);