summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-01-13 11:54:18 -0700
committerMartin Roth <martinroth@google.com>2016-01-14 19:15:58 +0100
commitbaf00e6b28efcf02497a566fa6f0f43d11304406 (patch)
tree69bbabfe957d75d4209b5799a940acf260295db5 /src/soc/intel
parenta6e77027870826539f3dd4835c3b9dbc48f216c8 (diff)
downloadcoreboot-baf00e6b28efcf02497a566fa6f0f43d11304406.tar.xz
intel/skylake/pcr.c: error out on invalid size in pcr read/write
The read and write routines take a number of bytes to write, which should be 1,2, or 4. We now return an error if an invalid size is specified. Change-Id: I93344bc0837c3715fc7660503f405c8878eb711c Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/12936 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/skylake/pcr.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/skylake/pcr.c b/src/soc/intel/skylake/pcr.c
index 7efbb2547a..b6de73c74c 100644
--- a/src/soc/intel/skylake/pcr.c
+++ b/src/soc/intel/skylake/pcr.c
@@ -63,7 +63,7 @@ static int pch_pcr_read(u8 pid, u16 offset, u32 size, void *data)
*(u8 *) data = read8(pcr_reg_address(pid, offset));
break;
default:
- break;
+ return -1;
}
return 0;
}
@@ -123,7 +123,7 @@ static int pch_pcr_write(u8 pid, u16 offset, u32 size, u32 data)
write8(pcr_reg_address(pid, offset), (u8) data);
break;
default:
- break;
+ return -1;
}
/* Ensure the writes complete. */
complete_write();