diff options
author | Yu-Ping Wu <yupingso@chromium.org> | 2019-10-09 16:11:47 +0800 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-10-17 15:03:21 +0000 |
commit | 31ec0c4fdccc856b8f1ab541c21d900b8347810a (patch) | |
tree | dad87f26b90a74b15bb36c3835c30d24e71387c8 /src/soc/mediatek/mt8183/memory.c | |
parent | ffb5ea3dc4b1189f39bdd4a2e288f0b973e759c1 (diff) | |
download | coreboot-31ec0c4fdccc856b8f1ab541c21d900b8347810a.tar.xz |
soc/mediatek/mt8183: Improve code formatting
This patch contains some minor changes including:
- Use lowercase hex literals
- Combine short lines
- Remove unnecessary curly braces
- Simplify struct initialization
- Leverage macro _SELPH_DQS_BITS
- Ensure whitespaces around binary operators
- Remove extra whitespaces after commas
- Change log level and remove unnecessary debug logs
BUG=none
BRANCH=kukui
TEST=emerge-kukui coreboot
Change-Id: I33616e6142325920c2fd7e6dc1dc88eb29c5cf34
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36011
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Diffstat (limited to 'src/soc/mediatek/mt8183/memory.c')
-rw-r--r-- | src/soc/mediatek/mt8183/memory.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/mediatek/mt8183/memory.c b/src/soc/mediatek/mt8183/memory.c index bd5c74c6dc..3d7668d702 100644 --- a/src/soc/mediatek/mt8183/memory.c +++ b/src/soc/mediatek/mt8183/memory.c @@ -43,7 +43,7 @@ static int mt_mem_test(void) (i == 0) ? "pass" : "fail", i); if (i != 0) { - dramc_show("DRAM memory test failed\n"); + printk(BIOS_ERR, "DRAM memory test failed\n"); return -1; } @@ -80,7 +80,7 @@ static int dram_run_fast_calibration(const struct dramc_param *dparam, return -1; } - if (dparam->header.config != config) { + if (dparam->header.config != config) { printk(BIOS_WARNING, "Incompatible config for calibration data from flash " "(expected: %#x, saved: %#x)\n", @@ -167,7 +167,7 @@ void mt_mem_init(struct dramc_param_ops *dparam_ops) set_source_to_flash(dparam->freq_params); dparam_ops->write_to_flash(dparam); printk(BIOS_DEBUG, "Calibration params saved to flash: " - "version=%#x, size=#%x\n", + "version=%#x, size=%#x\n", dparam->header.version, dparam->header.size); return; } |