diff options
| author | Lin Huang <hl@rock-chips.com> | 2016-07-26 10:29:45 +0800 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-08-09 00:22:51 +0200 |
| commit | 271a2c2763cac2421630d299937e0b8f3c9e9ea4 (patch) | |
| tree | f307eb743656ca05770d3ec97c00ddccae92e8ac /src/soc/rockchip | |
| parent | e6a2ecf8931275bb44729c4e2b52a6fcf2b1abd4 (diff) | |
| download | coreboot-271a2c2763cac2421630d299937e0b8f3c9e9ea4.tar.xz | |
rockchip/rk3399: sdram: correct read obs and set DQS driver register
We were using the wrong register when reading the obs value and setting
the DQS driver. This did not affect LPDDR3 performance, but still needs
to be fixed.
BUG=none
BRANCH=none
TEST=boot from kevin
Change-Id: I144f575e27fba11872a8c5463ab1e2986f385ede
Signed-off-by: Martin Roth <martinroth@chromium.org>
Original-Commit-Id: 98221e6b03fc09cbf62af29a270e7a8aa8dfb986
Original-Change-Id: Ie179f9a2955c5712951d40b3ada9c14a51c09c8d
Original-Signed-off-by: Lin Huang <hl@rock-chips.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/363170
Original-Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/16052
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc/rockchip')
| -rw-r--r-- | src/soc/rockchip/rk3399/sdram.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c index a237a80c7b..9587696992 100644 --- a/src/soc/rockchip/rk3399/sdram.c +++ b/src/soc/rockchip/rk3399/sdram.c @@ -424,7 +424,7 @@ static void phy_io_config(u32 channel, /* PHY_926 PHY_PAD_DATA_DRIVE */ clrsetbits_le32(&denali_phy[926], 0x7 << 6, mode_sel << 6); /* PHY_927 PHY_PAD_DQS_DRIVE */ - clrsetbits_le32(&denali_phy[926], 0x7 << 6, mode_sel << 6); + clrsetbits_le32(&denali_phy[927], 0x7 << 6, mode_sel << 6); /* PHY_928 PHY_PAD_ADDR_DRIVE */ clrsetbits_le32(&denali_phy[928], 0x7 << 14, mode_sel << 14); /* PHY_929 PHY_PAD_CLK_DRIVE */ @@ -441,7 +441,7 @@ static void phy_io_config(u32 channel, /* PHY_926 PHY_PAD_DATA_DRIVE */ clrsetbits_le32(&denali_phy[926], 0x3 << 9, mode_sel << 9); /* PHY_927 PHY_PAD_DQS_DRIVE */ - clrsetbits_le32(&denali_phy[926], 0x3 << 9, mode_sel << 9); + clrsetbits_le32(&denali_phy[927], 0x3 << 9, mode_sel << 9); /* PHY_928 PHY_PAD_ADDR_DRIVE */ clrsetbits_le32(&denali_phy[928], 0x3 << 17, mode_sel << 17); /* PHY_929 PHY_PAD_CLK_DRIVE */ @@ -720,7 +720,7 @@ static int data_training(u32 channel, */ obs_0 = read32(&denali_phy[532]); obs_1 = read32(&denali_phy[660]); - obs_2 = read32(&denali_phy[789]); + obs_2 = read32(&denali_phy[788]); if (((obs_0 >> 30) & 0x3) || ((obs_1 >> 30) & 0x3) || ((obs_2 >> 30) & 0x3)) |