summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2020-11-09 09:47:00 -0800
committerDuncan Laurie <dlaurie@chromium.org>2020-11-20 00:27:21 +0000
commit3b70ad8ecfadcc393a15f98cbf476a34dd6b135c (patch)
tree6905c1b44ca54dffb80f720336c15c3a58d6ff57 /src/soc
parent15ca9034b39a7fe0d883c0406d3c7591163d33f4 (diff)
downloadcoreboot-3b70ad8ecfadcc393a15f98cbf476a34dd6b135c.tar.xz
soc/intel/common: Use per-soc definition for BAR sizes
The various platform BARs are not always the same size across different SOCs, so use the defined size rather than a hardcoded value. This results in the following change on TGL which increased the MCHBAR size to 128K: -system 00:00: [mem 0xfedc0000-0xfeddffff] has been reserved +system 00:00: [mem 0xfedc0000-0xfedc7fff] has been reserved And fixes the following error output from the kernel: resource sanity check: requesting [mem 0xfedc0000-0xfedcdfff], which spans more than pnp 00:00 [mem 0xfedc0000-0xfedc7fff] Change-Id: I82796c2fc81dec883f3c69ae7bdcedc7d3f16c64 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47378 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/common/block/acpi/acpi/northbridge.asl6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl
index bac059076a..b4b746542e 100644
--- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl
+++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl
@@ -253,17 +253,17 @@ Device (PDRC)
/* MCH BAR _BAS will be updated in _CRS below according to
* B0:D0:F0:Reg.48h
*/
- Memory32Fixed (ReadWrite, 0, 0x08000, MCHB)
+ Memory32Fixed (ReadWrite, 0, MCH_BASE_SIZE, MCHB)
/* DMI BAR _BAS will be updated in _CRS below according to
* B0:D0:F0:Reg.68h
*/
- Memory32Fixed (ReadWrite, 0, 0x01000, DMIB)
+ Memory32Fixed (ReadWrite, 0, DMI_BASE_SIZE, DMIB)
/* EP BAR _BAS will be updated in _CRS below according to
* B0:D0:F0:Reg.40h
*/
- Memory32Fixed (ReadWrite, 0, 0x01000, EGPB)
+ Memory32Fixed (ReadWrite, 0, EP_BASE_SIZE, EGPB)
/* PCI Express BAR _BAS and _LEN will be updated in
* _CRS below according to B0:D0:F0:Reg.60h