diff options
| author | Felix Singer <felixsinger@posteo.net> | 2021-04-19 01:42:33 +0200 |
|---|---|---|
| committer | Michael Niewöhner <foss@mniewoehner.de> | 2021-04-20 19:13:09 +0000 |
| commit | b03e497ef16e9e38ba9220d31131a6bfdef35390 (patch) | |
| tree | 860d494b63ebdc75696f4fa74cd61a033f16adbb /src/soc | |
| parent | 2a3689f0e4f7727fe75c2bf16532d4d1330a3f74 (diff) | |
| download | coreboot-b03e497ef16e9e38ba9220d31131a6bfdef35390.tar.xz | |
soc/intel/cannonlake/romstage: Reuse device pointer
Reuse `dev` pointer for SmbusEnable configuration and remove `smbus`
pointer.
Change-Id: I7ad7cdeb632eb52ae02b60ca51e7d4845dffdb0d
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52490
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/intel/cannonlake/romstage/fsp_params.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/cannonlake/romstage/fsp_params.c b/src/soc/intel/cannonlake/romstage/fsp_params.c index c1fe5a7bf1..5eddf85770 100644 --- a/src/soc/intel/cannonlake/romstage/fsp_params.c +++ b/src/soc/intel/cannonlake/romstage/fsp_params.c @@ -136,7 +136,6 @@ static void soc_memory_init_params(FSPM_UPD *mupd, const config_t *config) void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) { const struct device *dev = pcidev_path_on_root(PCH_DEVFN_LPC); - const struct device *smbus = pcidev_path_on_root(PCH_DEVFN_SMBUS); assert(dev != NULL); const config_t *config = config_of(dev); FSP_M_CONFIG *m_cfg = &mupd->FspmConfig; @@ -145,10 +144,11 @@ void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) soc_memory_init_params(mupd, config); /* Enable SMBus controller based on config */ - if (!smbus) + dev = pcidev_path_on_root(PCH_DEVFN_SMBUS); + if (!dev) m_cfg->SmbusEnable = 0; else - m_cfg->SmbusEnable = smbus->enabled; + m_cfg->SmbusEnable = dev->enabled; /* Set debug probe type */ m_cfg->PlatformDebugConsent = |