summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2013-10-28 14:18:38 -0700
committerAaron Durbin <adurbin@google.com>2014-02-24 18:44:08 +0100
commite549e94d03305ce142d973ebb1f8383d37d3a491 (patch)
treef2d43551e30230f81e6e4f5df951231504c43039 /src/soc
parent063c87358880ac911764b5a8fe4cdf09003278e1 (diff)
downloadcoreboot-e549e94d03305ce142d973ebb1f8383d37d3a491.tar.xz
baytrail: IOSF write functions need to set data before control
The data needs to be available in the register before the control bits are set to make the write happen. BUG=chrome-os-partner:23507 BRANCH=rambi TEST=successfully ungate power on PUNIT on rambi Change-Id: I8fae60d5385ce9a401c1dec9cbb39b70d157a6c2 Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/174898 Reviewed-by: Stefan Reinauer <reinauer@chromium.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/4906 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/baytrail/iosf.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/baytrail/iosf.c b/src/soc/intel/baytrail/iosf.c
index e35e34f168..b9f1531986 100644
--- a/src/soc/intel/baytrail/iosf.c
+++ b/src/soc/intel/baytrail/iosf.c
@@ -56,8 +56,8 @@ void iosf_bunit_write(int reg, uint32_t val)
uint32_t cr = IOSF_OPCODE(IOSF_OP_WRITE_BUNIT) |
IOSF_PORT(IOSF_PORT_BUNIT) | IOSF_REG(reg) | IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_dunit_read(int reg)
@@ -91,8 +91,8 @@ void iosf_dunit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_SYSMEMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}
uint32_t iosf_punit_read(int reg)
@@ -111,6 +111,6 @@ void iosf_punit_write(int reg, uint32_t val)
IOSF_PORT(IOSF_PORT_PMC) | IOSF_REG(reg) |
IOSF_BYTE_EN;
- write_iosf_reg(MCR_REG, cr);
write_iosf_reg(MDR_REG, val);
+ write_iosf_reg(MCR_REG, cr);
}