summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorBarnali Sarkar <barnali.sarkar@intel.com>2017-06-07 13:47:51 +0530
committerAaron Durbin <adurbin@chromium.org>2017-06-09 18:49:56 +0200
commit97daf988060f0b73b889a78983718f679753ffbd (patch)
tree7c3264c146abce03c2dbc7cc64dabc22cb4d5587 /src/soc
parent682355ab16a946dce3f989b9581196a888b17ee8 (diff)
downloadcoreboot-97daf988060f0b73b889a78983718f679753ffbd.tar.xz
soc/intel/apollolake: Remove duplication of find_microcode_patch() code
Since get_microcode_info() is aleady searching for the microcode in cbfs, we can just add a intel_microcode_load_unlocked() call here to update the microcode. No need to duplicate finding microcode step during pre_mp_init() function. Change-Id: I525cab0ecc7826554f0a1209862e6357d1c7a9a6 Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com> Reviewed-on: https://review.coreboot.org/20088 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/apollolake/cpu.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 9e951aa57d..1a9c8db995 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -118,9 +118,6 @@ static void pre_mp_init(void)
{
x86_setup_mtrrs_with_detect();
x86_mtrr_check();
-
- /* Make sure BSP is using the microcode from cbfs */
- intel_update_microcode_from_cbfs();
}
/* Find CPU topology */
@@ -140,6 +137,9 @@ static void get_microcode_info(const void **microcode, int *parallel)
{
*microcode = intel_microcode_find();
*parallel = 1;
+
+ /* Make sure BSP is using the microcode from cbfs */
+ intel_microcode_load_unlocked(*microcode);
}
static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,