summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-05 11:35:27 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-07 05:41:06 +0000
commitd78866399c389ac3195cb7841bac68ae2b22c358 (patch)
tree9eaf3853746482cb5240086173b1038eff6cfeac /src/soc
parent3dddf4fb41848c2b816c0ca1470a58f3418028f3 (diff)
downloadcoreboot-d78866399c389ac3195cb7841bac68ae2b22c358.tar.xz
intel/icelake,skylake,cannonlake: Drop unused parameter
Change-Id: I0900c3b893d72063cc8df5d8ac370cf9d54df17a Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34697 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/cannonlake/smmrelocate.c7
-rw-r--r--src/soc/intel/icelake/smmrelocate.c7
-rw-r--r--src/soc/intel/skylake/smmrelocate.c7
3 files changed, 6 insertions, 15 deletions
diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c
index 980702ffb6..3ee94e72d9 100644
--- a/src/soc/intel/cannonlake/smmrelocate.c
+++ b/src/soc/intel/cannonlake/smmrelocate.c
@@ -171,8 +171,7 @@ void smm_relocation_handler(int cpu, uintptr_t curr_smbase,
write_smrr(relo_params);
}
-static void fill_in_relocation_params(struct device *dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
void *handler_base;
size_t handler_size;
@@ -256,11 +255,9 @@ static void setup_ied_area(struct smm_relocation_params *params)
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
if (smm_reloc_params.ied_size)
setup_ied_area(&smm_reloc_params);
diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c
index 63048eb913..9630844123 100644
--- a/src/soc/intel/icelake/smmrelocate.c
+++ b/src/soc/intel/icelake/smmrelocate.c
@@ -170,8 +170,7 @@ void smm_relocation_handler(int cpu, uintptr_t curr_smbase,
write_smrr(relo_params);
}
-static void fill_in_relocation_params(struct device *dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
void *handler_base;
size_t handler_size;
@@ -255,11 +254,9 @@ static void setup_ied_area(struct smm_relocation_params *params)
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
if (smm_reloc_params.ied_size)
setup_ied_area(&smm_reloc_params);
diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c
index 816e1a8963..6e2cf98ae2 100644
--- a/src/soc/intel/skylake/smmrelocate.c
+++ b/src/soc/intel/skylake/smmrelocate.c
@@ -180,8 +180,7 @@ void smm_relocation_handler(int cpu, uintptr_t curr_smbase,
write_smrr(relo_params);
}
-static void fill_in_relocation_params(struct device *dev,
- struct smm_relocation_params *params)
+static void fill_in_relocation_params(struct smm_relocation_params *params)
{
void *handler_base;
size_t handler_size;
@@ -265,11 +264,9 @@ static void setup_ied_area(struct smm_relocation_params *params)
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
size_t *smm_save_state_size)
{
- struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
-
printk(BIOS_DEBUG, "Setting up SMI for CPU\n");
- fill_in_relocation_params(dev, &smm_reloc_params);
+ fill_in_relocation_params(&smm_reloc_params);
if (smm_reloc_params.ied_size)
setup_ied_area(&smm_reloc_params);