summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2019-05-08 15:09:29 -0600
committerDuncan Laurie <dlaurie@chromium.org>2019-05-09 15:34:53 +0000
commit643daed6b54970da4d83055649b6abc2a198a840 (patch)
tree270e043009575af9b30ed42c1755b657094f29a0 /src/soc
parent24047fefdac1d5abc1298a0da20340dc3d7eda48 (diff)
downloadcoreboot-643daed6b54970da4d83055649b6abc2a198a840.tar.xz
vendorcode/google/chromeos: Use explicit zero check in ACPI code
The ASL 2.0 syntax for "!X" resolves to "LNot(X)" which will evaluate the object as an integer and turn into a boolean. This may not do the right thing if the object is actually a string and it can lead to unexpected behavior. Instead be specific about the object type and check for zero or an empty string depending on what is being returned. This fixes an issue where some VPD keys were causing the search to stop and miss subsequent entries. Change-Id: I1688842964f9c2f81ca31073da9c2d71a8c81767 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32694 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc')
0 files changed, 0 insertions, 0 deletions