diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2020-03-09 14:05:49 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2020-05-20 00:08:21 +0000 |
| commit | 839f668d89e8cfb6fcd3aeaa21148d7644cb040e (patch) | |
| tree | 9ce08af5b83f1c9fce3e6057dd47f80313a6145b /src/soc | |
| parent | f36c38355b45a03b5ad009fae965024e2bfe5c90 (diff) | |
| download | coreboot-839f668d89e8cfb6fcd3aeaa21148d7644cb040e.tar.xz | |
soc/amd/picasso/acpi: Move _PIC method to root namespace
The _PIC method sets the interrupt model (PIC or APIC). It needs to be
defined at the root level for the kernel to find it. Previously this
method was never getting called, so we were always stuck in APIC mode.
BUG=b:139429446, b:147042464
BRANCH=none
TEST=Saw the method getting called
[ 1.251774] ACPI Debug: "PIC MODE: 0000000000000001"
Change-Id: Idd5e9646df8d56e7cbec2be8b4016c36d81e5fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/2095682
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41437
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/amd/picasso/acpi/pci_int.asl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl index 0f3d882a8b..f89a14e795 100644 --- a/src/soc/amd/picasso/acpi/pci_int.asl +++ b/src/soc/amd/picasso/acpi/pci_int.asl @@ -103,12 +103,13 @@ P3PR, 1, } - Method(_PIC, 0x01, NotSerialized) + Method(\_PIC, 0x01, NotSerialized) { If (Arg0) { \_SB.CIRQ() } + printf("PIC MODE: %o", Arg0) Store(Arg0, PMOD) } |