summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorMartin Roth <martinroth@chromium.org>2020-11-05 11:20:19 -0700
committerFelix Held <felix-coreboot@felixheld.de>2020-11-07 18:33:17 +0000
commit3190ba863daecf6ac9300f57beb8c7eae74b8c50 (patch)
tree54f5a3e44af21b8e08ddcb651c67fac9fbc965b0 /src/soc
parentb6ef297564b0ea173d889a47fbd5a811de532e99 (diff)
downloadcoreboot-3190ba863daecf6ac9300f57beb8c7eae74b8c50.tar.xz
soc/amd/common: Don't program GPIOs if the table isn't set
Currently, there's no check for the table being programmed. This skips programming a table if the table size is zero, or the pointer to the table has been set to NULL. BUG=None TEST=Set table pointer to NULL, table doesn't run. BRANCH=Zork Signed-off-by: Martin Roth <martinroth@chromium.org> Change-Id: I7d09b47e7d619428b64cc0695f220fb64c71ef4c Reviewed-on: https://review.coreboot.org/c/coreboot/+/47307 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/amd/common/block/gpio_banks/gpio.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index 74ea696448..91773d9966 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -187,6 +187,8 @@ void program_gpios(const struct soc_amd_gpio *gpio_list_ptr, size_t size)
size_t gev_items;
const bool can_set_smi_flags = !(CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) &&
ENV_SEPARATE_VERSTAGE);
+ if (!gpio_list_ptr || !size)
+ return;
/*
* Disable blocking wake/interrupt status generation while updating