summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2017-04-06 13:23:46 +0200
committerWerner Zeh <werner.zeh@siemens.com>2017-04-28 06:18:27 +0200
commit27e6042bb7d0b16b56f9b590dce42e5314385256 (patch)
treed1ecf092c7b6cc65930474ff59084b723b04461b /src/soc
parent80656afc40ee687372fc9b63d12b6ebe15194ec1 (diff)
downloadcoreboot-27e6042bb7d0b16b56f9b590dce42e5314385256.tar.xz
intel/apollolake: Switch FADT to ACPI version 3.0
The current implementation of the FADT structure is only ACPI 3.0 compliant. Setting the version to ACPI 5.0 results in a corrupt FADT. Linux seems to be able to deal with it but Windows 10 hangs in a really early stage without any notification to the user. If ACPI 5.0 is mandatory, the FADT structure needs to be adjusted to match the specification. Therefore the members sleep_ctl and sleep_stat needs to be added to FADT structure. Change-Id: I51c7a7a84d10283f5c2a8a2c57257d53bbdee7ed Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/19146 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/apollolake/acpi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 2adb76e2c4..6588488e5f 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -87,8 +87,8 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
{
const uint16_t pmbase = ACPI_PMIO_BASE;
- /* Use ACPI 5.0 revision. */
- fadt->header.revision = ACPI_FADT_REV_ACPI_5_0;
+ /* Use ACPI 3.0 revision. */
+ fadt->header.revision = ACPI_FADT_REV_ACPI_3_0;
fadt->sci_int = acpi_sci_irq();
fadt->smi_cmd = APM_CNT;