summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-08-10 20:43:53 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-11 14:27:57 +0000
commitb026c7c65a839e509fbbec9718e3b4198bcfbe65 (patch)
tree8b7c2709eec3ebc48ded386815faff39c3b99528 /src/soc
parent3999aa6cdb1e1ed1a415aa79903e21193079eca6 (diff)
downloadcoreboot-b026c7c65a839e509fbbec9718e3b4198bcfbe65.tar.xz
soc/amd/common/espi_util: clarify espi_open_io_window
Calling espi_open_generic_io_window in espi_open_io_window depends on the condition in the preceding if statement, so move the command into an else block to make it more obvious that this is the case. TEST=Timeless build results in identical image. Change-Id: I3039817afd79c30a2df2f2f54e7848f52dc2c487 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44353 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/amd/common/block/lpc/espi_util.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c
index 1b617fcccd..0878fb7663 100644
--- a/src/soc/amd/common/block/lpc/espi_util.c
+++ b/src/soc/amd/common/block/lpc/espi_util.c
@@ -183,9 +183,9 @@ int espi_open_io_window(uint16_t base, size_t size)
if (std_io != -1) {
espi_enable_decode(std_io);
return 0;
+ } else {
+ return espi_open_generic_io_window(base, size);
}
-
- return espi_open_generic_io_window(base, size);
}
static int espi_find_mmio_window(uint32_t win_base)