diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-07-12 13:26:52 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2019-07-17 15:58:44 +0000 |
| commit | c14eb3b9505ec8177038434d1ada6718113e2e70 (patch) | |
| tree | a11a369d4595f71545540b6b15adafff1a7cc602 /src/soc | |
| parent | 1bc578ac451322ac11bcbf71ec89d69fcb74bd68 (diff) | |
| download | coreboot-c14eb3b9505ec8177038434d1ada6718113e2e70.tar.xz | |
soc/rockchip/rk3288: Add fall through comment
Judging from the state machine on page 281 of the Rockchip RK3288
Technical Reference Manual (Rev 1.0 - Jun 2015), the fall through
from the INIT_MEM -> CONF states is intentional, since that is the
only way to get to the ACCESS state. Add a comment to explain this.
Change-Id: I1d0cfea07211c54d6a906f5a7481c2c760f8ef0d
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1291959
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34296
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/rockchip/rk3288/sdram.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/soc/rockchip/rk3288/sdram.c b/src/soc/rockchip/rk3288/sdram.c index 808ff963a8..53c594a4b3 100644 --- a/src/soc/rockchip/rk3288/sdram.c +++ b/src/soc/rockchip/rk3288/sdram.c @@ -908,6 +908,7 @@ static void move_to_access_state(u32 chnum) while ((read32(&ddr_pctl_regs->stat) & PCTL_STAT_MSK) != CONF) ; + /* fall through - enter config next to get to access state */ case CONF: write32(&ddr_pctl_regs->sctl, GO_STATE); while ((read32(&ddr_pctl_regs->stat) & PCTL_STAT_MSK) |