summaryrefslogtreecommitdiff
path: root/src/southbridge/amd
diff options
context:
space:
mode:
authorPaul Menzel <pmenzel@molgen.mpg.de>2018-11-10 11:27:02 +0100
committerPatrick Georgi <pgeorgi@google.com>2018-11-16 09:40:29 +0000
commit9eb4d0a0692ca960d6ed1ad14c11e27b32e1f419 (patch)
tree145382477fc8cd7f444996af581b43810d4d5ff9 /src/southbridge/amd
parentdee0f8845bf2dcb45fd2f532d068dd3e7e2f9d3c (diff)
downloadcoreboot-9eb4d0a0692ca960d6ed1ad14c11e27b32e1f419.tar.xz
sb/amd: Remove dead assignment in SPI driver
Value stored to 'cmd' is never read Change-Id: I794b6e12f5af272705cd996f7ca5099e9b9dbfc7 Found-by: scan-build from clang 6 Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-on: https://review.coreboot.org/29568 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/southbridge/amd')
-rw-r--r--src/southbridge/amd/agesa/hudson/spi.c2
-rw-r--r--src/southbridge/amd/cimx/sb800/spi.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/southbridge/amd/agesa/hudson/spi.c b/src/southbridge/amd/agesa/hudson/spi.c
index 74c4711536..94846514ce 100644
--- a/src/southbridge/amd/agesa/hudson/spi.c
+++ b/src/southbridge/amd/agesa/hudson/spi.c
@@ -132,7 +132,7 @@ static int spi_ctrlr_xfer(const struct spi_slave *slave, const void *dout,
reset_internal_fifo_pointer();
/* Skip the bytes we sent. */
for (count = 0; count < bytesout; count++) {
- cmd = spi_read(SPI_REG_FIFO);
+ spi_read(SPI_REG_FIFO);
}
for (count = 0; count < bytesin; count++, din++) {
diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c
index ec18454cc7..574c0621db 100644
--- a/src/southbridge/amd/cimx/sb800/spi.c
+++ b/src/southbridge/amd/cimx/sb800/spi.c
@@ -95,7 +95,7 @@ static int spi_ctrlr_xfer(const struct spi_slave *slave, const void *dout,
reset_internal_fifo_pointer();
/* Skip the bytes we sent. */
for (count = 0; count < bytesout; count++) {
- cmd = read8((void *)(spibar + 0x0C));
+ read8((void *)(spibar + 0x0C));
}
reset_internal_fifo_pointer();