diff options
| author | Martin Roth <martinroth@google.com> | 2017-07-20 20:54:36 -0600 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-08-25 01:16:10 +0000 |
| commit | 0ff2e01e809439efbf8cbe85bb6b48315b8a945a (patch) | |
| tree | 0c10a5c2ec8fbc01d8b9baf475538c6de88285ce /src/southbridge/amd | |
| parent | d3af7d7fcc769d898966b7559276698e71d9b201 (diff) | |
| download | coreboot-0ff2e01e809439efbf8cbe85bb6b48315b8a945a.tar.xz | |
amd/pi/hudson: Move oem_fan_control()
It was not intentional to change oem_fan_control() to non-static
with commit
23e5ba9 binarypi mainboards: Clean up IS_ENABLED fan control
Every platform except bettong had its own static version of
oem_fan_control, so remove the definition of oem_fan_control from imc.h,
and move it out of imc.c into bettong's BiosCallOuts.c.
Change-Id: Ie95ac1fd3a57259bb35796903aa8753ef0e70d70
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/21189
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge/amd')
| -rw-r--r-- | src/southbridge/amd/pi/hudson/imc.c | 18 | ||||
| -rw-r--r-- | src/southbridge/amd/pi/hudson/imc.h | 5 |
2 files changed, 0 insertions, 23 deletions
diff --git a/src/southbridge/amd/pi/hudson/imc.c b/src/southbridge/amd/pi/hudson/imc.c index d11bb88801..53e97fbae3 100644 --- a/src/southbridge/amd/pi/hudson/imc.c +++ b/src/southbridge/amd/pi/hudson/imc.c @@ -81,21 +81,3 @@ void enable_imc_thermal_zone(void) WaitForEcLDN9MailboxCmdAck(&StdHeader); } #endif - -/* Bettong Hardware Monitor Fan Control - * Hardware limitation: - * HWM will fail to read the input temperature via I2C if other - * software switches the I2C address. AMD recommends using IMC - * to control fans, instead of HWM. - */ -void oem_fan_control(FCH_DATA_BLOCK *FchParams) -{ - /* Enable IMC fan control. the recommand way */ - imc_reg_init(); - - FchParams->Imc.ImcEnable = TRUE; - FchParams->Hwm.HwmControl = 1; /* 1 IMC, 0 HWM */ - FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ - - LibAmdMemFill(&(FchParams->Imc.EcStruct), 0, sizeof(FCH_EC), FchParams->StdHeader); -} diff --git a/src/southbridge/amd/pi/hudson/imc.h b/src/southbridge/amd/pi/hudson/imc.h index 7e407304eb..0fcc187a4e 100644 --- a/src/southbridge/amd/pi/hudson/imc.h +++ b/src/southbridge/amd/pi/hudson/imc.h @@ -16,12 +16,7 @@ #ifndef HUDSON_IMC_H #define HUDSON_IMC_H -#include "Porting.h" -#include "AGESA.h" -#include <FchCommonCfg.h> - void imc_reg_init(void); void enable_imc_thermal_zone(void); -void oem_fan_control(FCH_DATA_BLOCK *FchParams); #endif |