diff options
| author | Kevin Paul Herbert <kph@meraki.net> | 2015-02-25 00:36:51 -0800 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2015-02-27 18:15:33 +0100 |
| commit | 4104e6cd30ba80f93e764e5036f79dd7a60d5b1c (patch) | |
| tree | bf50e439a9c1c84692c81876f3012796cb3221cc /src/southbridge/amd | |
| parent | c684d05b0fa66f86b3c94ecd46388858d8e5dcaa (diff) | |
| download | coreboot-4104e6cd30ba80f93e764e5036f79dd7a60d5b1c.tar.xz | |
x86: Fix pointer arithmetic regressions from MMIO changes
During the development of commit bde6d30 (x86: Change MMIO addr
in readN(addr)/writeN(addr, val) to pointer), there were several iterations
and patterns tried. An intermediate pattern was the use of u32 pointers,
and division by sizeof(u32). Some of these did not get properly
changed to pointer types of length 1, causing a regression in
the Intel Ibex Peak SATA driver, fixed in commit 9b5f137
(Intel ibexpeak: Fix SATA configuration).
Other regressions of this pattern are fixed here. I audited all changes
to u32 types, and the other ones are safe.
Change-Id: I9e73ac8f4329df8bf0cdd1a14759f0280f974052
Signed-off-by: Kevin Paul Herbert <kph@meraki.net>
Reviewed-on: http://review.coreboot.org/8530
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/southbridge/amd')
| -rw-r--r-- | src/southbridge/amd/agesa/hudson/enable_usbdebug.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/amd8111/nic.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/southbridge/amd/agesa/hudson/enable_usbdebug.c b/src/southbridge/amd/agesa/hudson/enable_usbdebug.c index 5463d2bb90..9deeb453ba 100644 --- a/src/southbridge/amd/agesa/hudson/enable_usbdebug.c +++ b/src/southbridge/amd/agesa/hudson/enable_usbdebug.c @@ -48,7 +48,7 @@ void pci_ehci_dbg_set_port(pci_devfn_t dev, unsigned int port) reg32 &= ~(0xf << 28); reg32 |= (port << 28); reg32 |= (1 << 27); /* Enable Debug Port port number remapping. */ - write32(base_regs + (DEBUGPORT_MISC_CONTROL / sizeof(u32)), reg32); + write32(base_regs + DEBUGPORT_MISC_CONTROL, reg32); } diff --git a/src/southbridge/amd/amd8111/nic.c b/src/southbridge/amd/amd8111/nic.c index 21df6c05d6..05ca871d89 100644 --- a/src/southbridge/amd/amd8111/nic.c +++ b/src/southbridge/amd/amd8111/nic.c @@ -11,7 +11,7 @@ #include "amd8111.h" -#define CMD3 (0x54/(sizeof(u32))) +#define CMD3 0x54 typedef enum { VAL3 = (1 << 31), /* VAL bit for byte 3 */ |