diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-07-12 10:34:06 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-07-19 09:57:54 +0000 |
| commit | 4c33a3aaa38c94b103c51aa6a5553a4b1355c435 (patch) | |
| tree | 57b215944720d992ea1ded6bdd774d79411a687f /src/southbridge/amd | |
| parent | 78107939de6e2c4b66de6bd1370607f7d3a600f0 (diff) | |
| download | coreboot-4c33a3aaa38c94b103c51aa6a5553a4b1355c435.tar.xz | |
src: Make implicit fall throughs explicit
Implicit fall throughs are a perpetual source of bugs and Coverity Scan
issues, so let's squash them once and for all. GCC can flag implicit fall
throughs using the -Wimplicit-fallthrough warning, and this should
ensure no more enter the code base. However, many fall throughs are
intentional, and we can use the following comment style to have GCC
suppress the warning.
switch (x) {
case 1:
y += 1;
/* fall through */
case 2:
y += 2;
/* fall through - but this time with an explanation */
default:
y += 3;
}
This patch adds comments for all remaining intentional fall throughs,
and tweaks some existing fall through comments to fit the syntax that
GCC expects.
Change-Id: I1d75637a434a955a58d166ad203e49620d7395ed
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34297
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Diffstat (limited to 'src/southbridge/amd')
| -rw-r--r-- | src/southbridge/amd/agesa/hudson/hudson.c | 9 | ||||
| -rw-r--r-- | src/southbridge/amd/cimx/sb800/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/cimx/sb900/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/sb700/lpc.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/sb800/lpc.c | 2 |
5 files changed, 14 insertions, 3 deletions
diff --git a/src/southbridge/amd/agesa/hudson/hudson.c b/src/southbridge/amd/agesa/hudson/hudson.c index 25997d2e9d..4c06e87281 100644 --- a/src/southbridge/amd/agesa/hudson/hudson.c +++ b/src/southbridge/amd/agesa/hudson/hudson.c @@ -117,21 +117,24 @@ void hudson_enable(struct device *dev) case PCI_DEVFN(0x12, 0): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_12_0); - case PCI_DEVFN(0x12, 2): /* Fall through */ + /* fall through */ + case PCI_DEVFN(0x12, 2): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_12_2); break; case PCI_DEVFN(0x13, 0): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_13_0); - case PCI_DEVFN(0x13, 2): /* Fall through */ + /* fall through */ + case PCI_DEVFN(0x13, 2): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_13_2); break; case PCI_DEVFN(0x16, 0): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_16_0); - case PCI_DEVFN(0x16, 2): /* Fall through */ + /* fall through */ + case PCI_DEVFN(0x16, 2): if (dev->enabled == 0) hudson_disable_usb(USB_EN_DEVFN_16_2); break; diff --git a/src/southbridge/amd/cimx/sb800/lpc.c b/src/southbridge/amd/cimx/sb800/lpc.c index 483d185e32..79f402993f 100644 --- a/src/southbridge/amd/cimx/sb800/lpc.c +++ b/src/southbridge/amd/cimx/sb800/lpc.c @@ -172,8 +172,10 @@ void lpc_enable_childrens_resources(struct device *dev) switch (var_num) { case 3: pci_write_config16(dev, 0x90, reg_var[2]); + /* fall through */ case 2: pci_write_config16(dev, 0x66, reg_var[1]); + /* fall through */ case 1: //pci_write_config16(dev, 0x64, reg_var[0]); //cause filo can not find sata break; diff --git a/src/southbridge/amd/cimx/sb900/lpc.c b/src/southbridge/amd/cimx/sb900/lpc.c index 8fcb947eb6..8e7c1cc67f 100644 --- a/src/southbridge/amd/cimx/sb900/lpc.c +++ b/src/southbridge/amd/cimx/sb900/lpc.c @@ -170,8 +170,10 @@ void lpc_enable_childrens_resources(struct device *dev) switch (var_num) { case 3: pci_write_config16(dev, 0x90, reg_var[2]); + /* fall through */ case 2: pci_write_config16(dev, 0x66, reg_var[1]); + /* fall through */ case 1: //pci_write_config16(dev, 0x64, reg_var[0]); //cause filo can not find sata break; diff --git a/src/southbridge/amd/sb700/lpc.c b/src/southbridge/amd/sb700/lpc.c index b7f0dc3bbf..eb171e605a 100644 --- a/src/southbridge/amd/sb700/lpc.c +++ b/src/southbridge/amd/sb700/lpc.c @@ -230,8 +230,10 @@ static void sb700_lpc_enable_childrens_resources(struct device *dev) switch (var_num) { case 3: pci_write_config16(dev, 0x90, reg_var[2]); + /* fall through */ case 2: pci_write_config16(dev, 0x66, reg_var[1]); + /* fall through */ case 1: pci_write_config16(dev, 0x64, reg_var[0]); break; diff --git a/src/southbridge/amd/sb800/lpc.c b/src/southbridge/amd/sb800/lpc.c index 74b63741a5..580138a470 100644 --- a/src/southbridge/amd/sb800/lpc.c +++ b/src/southbridge/amd/sb800/lpc.c @@ -222,8 +222,10 @@ static void sb800_lpc_enable_childrens_resources(struct device *dev) switch (var_num) { case 3: pci_write_config16(dev, 0x90, reg_var[2]); + /* fall through */ case 2: pci_write_config16(dev, 0x66, reg_var[1]); + /* fall through */ case 1: pci_write_config16(dev, 0x64, reg_var[0]); break; |