diff options
| author | Varad Gautam <varadgautam@gmail.com> | 2015-03-11 09:54:41 +0530 |
|---|---|---|
| committer | Marc Jones <marc.jones@se-eng.com> | 2015-04-06 19:40:00 +0200 |
| commit | 06ef04604570d402687245521731053c66888b15 (patch) | |
| tree | ce0fd5b994094f7228d7c18245f8758fd48676ee /src/southbridge/amd | |
| parent | 015f0aea5dc0cd391ddc34c1db6591d93d08e8a9 (diff) | |
| download | coreboot-06ef04604570d402687245521731053c66888b15.tar.xz | |
global: Refactor get_option usage
Restructure get_option() calls to avoid unnecessary return value checks
by pre-assigning defaults to the options being retrieved.
Change-Id: I9159afe149a8eeed0785d1efd6eee8420b88b8f4
Signed-off-by: Varad Gautam <varadgautam@gmail.com>
Reviewed-on: http://review.coreboot.org/8631
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Diffstat (limited to 'src/southbridge/amd')
| -rw-r--r-- | src/southbridge/amd/sb600/sata.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/southbridge/amd/sb600/sata.c b/src/southbridge/amd/sb600/sata.c index 2ff718230a..34ac0aca54 100644 --- a/src/southbridge/amd/sb600/sata.c +++ b/src/southbridge/amd/sb600/sata.c @@ -119,10 +119,8 @@ static void sata_init(struct device *dev) pci_write_config8(dev, 0x40, byte); // 1 means IDE, 0 means AHCI - if (get_option(&i, "sata_mode") != CB_SUCCESS) { - // no cmos option - i = CONFIG_SATA_MODE; - } + i = CONFIG_SATA_MODE; + get_option(&i, "sata_mode"); printk(BIOS_INFO, "%s: setting sata mode = %s\n", __func__, (i == SATA_MODE_IDE)?"ide":"ahci" ); dword = pci_read_config32(dev, 0x8); |