diff options
| author | Vladimir Serbinenko <phcoder@gmail.com> | 2013-12-20 17:47:19 +0100 |
|---|---|---|
| committer | Vladimir Serbinenko <phcoder@gmail.com> | 2013-12-24 14:40:49 +0100 |
| commit | b32816e9a5564e3604c3829b92727b54356f4777 (patch) | |
| tree | e903e61e25651a410426a08df203d193d99f6166 /src/southbridge/amd | |
| parent | 50ecb9c11131a31bc6f0d0e0b5fcbd5aab36e5e0 (diff) | |
| download | coreboot-b32816e9a5564e3604c3829b92727b54356f4777.tar.xz | |
Remove PCI_ROM_RUN option
The main purpose of option rom is to supply int* handlers.
But supplying those is outside of coreboot scope and if someone needs those
they should run SeaBIOS anyway which runs the option roms wonderfully.
Running VGA oprom is kept because they're needed to init graphics.
This patch still keeps the options to include the option roms to make them
available to SeaBIOS.
Change-Id: I646334cf88094d3bf8f527779a68a07e0b4b93ec
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/4545
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'src/southbridge/amd')
| -rw-r--r-- | src/southbridge/amd/sb600/ide.c | 5 | ||||
| -rw-r--r-- | src/southbridge/amd/sb700/ide.c | 4 | ||||
| -rw-r--r-- | src/southbridge/amd/sb800/ide.c | 4 |
3 files changed, 0 insertions, 13 deletions
diff --git a/src/southbridge/amd/sb600/ide.c b/src/southbridge/amd/sb600/ide.c index 27001243a8..443ca74781 100644 --- a/src/southbridge/amd/sb600/ide.c +++ b/src/southbridge/amd/sb600/ide.c @@ -44,11 +44,6 @@ static void ide_init(struct device *dev) dword = pci_read_config16(dev, 0x4); dword |= 1 << 2; pci_write_config16(dev, 0x4, dword); - -#if CONFIG_PCI_ROM_RUN - pci_dev_init(dev); -#endif - } static struct pci_operations lops_pci = { diff --git a/src/southbridge/amd/sb700/ide.c b/src/southbridge/amd/sb700/ide.c index b2378ced31..982c9294a3 100644 --- a/src/southbridge/amd/sb700/ide.c +++ b/src/southbridge/amd/sb700/ide.c @@ -59,10 +59,6 @@ static void ide_init(struct device *dev) byte |= 1 << 4; pci_write_config8(sm_dev, 0xAD, byte); } - -#if CONFIG_PCI_ROM_RUN - pci_dev_init(dev); -#endif } static struct pci_operations lops_pci = { diff --git a/src/southbridge/amd/sb800/ide.c b/src/southbridge/amd/sb800/ide.c index 69dfea4f1e..e54cf5d12a 100644 --- a/src/southbridge/amd/sb800/ide.c +++ b/src/southbridge/amd/sb800/ide.c @@ -57,10 +57,6 @@ static void ide_init(struct device *dev) byte |= 1 << 4; pci_write_config8(dev, 0xAD, byte); } - -#if CONFIG_PCI_ROM_RUN - pci_dev_init(dev); -#endif } static struct pci_operations lops_pci = { |