diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-04-19 13:01:09 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-04-21 08:59:29 +0000 |
| commit | 0a937754ee81ba7491d9687f9473096d8364e9f4 (patch) | |
| tree | 808d4ca9b4e5aae44140f94b0eb731664b21e798 /src/southbridge/intel/bd82x6x | |
| parent | 8d94b36eed2a182fab008e5477a4eddc4dd282df (diff) | |
| download | coreboot-0a937754ee81ba7491d9687f9473096d8364e9f4.tar.xz | |
sb/intel/x/sata.c: Use `get_int_option` for `sata_mode`
Change-Id: Ifd1f3969281e67d1a6ab7eb99dd048799c0cb17d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47108
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/southbridge/intel/bd82x6x')
| -rw-r--r-- | src/southbridge/intel/bd82x6x/sata.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c index ba402edf8b..43ef9be3ad 100644 --- a/src/southbridge/intel/bd82x6x/sata.c +++ b/src/southbridge/intel/bd82x6x/sata.c @@ -35,8 +35,7 @@ static void sata_read_resources(struct device *dev) /* Assign fixed resources for IDE legacy mode */ - u8 sata_mode = 0; - get_option(&sata_mode, "sata_mode"); + u8 sata_mode = get_int_option("sata_mode", 0); if (sata_mode != 2) return; @@ -72,8 +71,7 @@ static void sata_read_resources(struct device *dev) static void sata_set_resources(struct device *dev) { /* work around bug in pci_dev_set_resources(), it bails out on FIXED */ - u8 sata_mode = 0; - get_option(&sata_mode, "sata_mode"); + u8 sata_mode = get_int_option("sata_mode", 0); if (sata_mode == 2) { unsigned int i; for (i = PCI_BASE_ADDRESS_0; i <= PCI_BASE_ADDRESS_3; i += 4) { @@ -92,7 +90,6 @@ static void sata_init(struct device *dev) u16 reg16; /* Get the chip configuration */ config_t *config = dev->chip_info; - u8 sata_mode; printk(BIOS_DEBUG, "SATA: Initializing...\n"); @@ -101,9 +98,8 @@ static void sata_init(struct device *dev) return; } - if (get_option(&sata_mode, "sata_mode") != CB_SUCCESS) - /* Default to AHCI */ - sata_mode = 0; + /* Default to AHCI */ + u8 sata_mode = get_int_option("sata_mode", 0); /* SATA configuration */ @@ -230,13 +226,11 @@ static void sata_enable(struct device *dev) /* Get the chip configuration */ config_t *config = dev->chip_info; u16 map = 0; - u8 sata_mode; if (!config) return; - if (get_option(&sata_mode, "sata_mode") != CB_SUCCESS) - sata_mode = 0; + u8 sata_mode = get_int_option("sata_mode", 0); /* * Set SATA controller mode early so the resource allocator can |