diff options
| author | Martin Roth <martinroth@google.com> | 2016-02-09 09:06:46 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-02-10 16:27:50 +0100 |
| commit | 59ff3400b0e90f8ec4dfbf361862e5dfe0a25285 (patch) | |
| tree | 8054f8070c3f73cd53c3a44a377887cefea24dc8 /src/southbridge/intel/common/firmware | |
| parent | a3e4833e5d30a904319811f420a7896675bfb12b (diff) | |
| download | coreboot-59ff3400b0e90f8ec4dfbf361862e5dfe0a25285.tar.xz | |
Kconfig: Move defaults for CBFS_SIZE
We want the question for CBFS size to be next to the rom size in the
mainboard directory, but that doesn't seem to work for how people
want to set the defaults. Instead of having the list of exceptions
to the size, just set the defaults at the end of kconfig.
- Move the defaults for chipsets not setting HAVE_INTEL_FIRMWARE into
the chipset Kconfigs (gm45, nehalem, sandybridge, x4x)
- Override the default for HAVE_INTEL_FIRMWARE on skylake.
- Move the HAVE_INTEL_FIRMWARE default setting into the firmware
Kconfig file
- Move the location of the default CBFS_SIZE=ROM_SIZE to the end of
the top level kconfig file, while leaving the question where it is.
Test=rebuild Kconfig files before and after the change, verify that
they are how they were intended to be.
Note: the Skylake boards actually changed value, because they were
picking up the 0x100000 from HAVE_INTEL_FIRMWARE instead of the
0x200000 desired. This was due to the SOC_INTEL_SKYLAKE being after
the HAVE_INTEL_FIRMWARE default. Affected boards were:
Google chell, glados, & lars and Intel kunimitsu.
Change-Id: I2963a7a7eab037955558d401f5573533674a664f
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/13645
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/southbridge/intel/common/firmware')
| -rw-r--r-- | src/southbridge/intel/common/firmware/Kconfig | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index 62b9a31690..c36b235cad 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -146,4 +146,10 @@ config LOCK_MANAGEMENT_ENGINE If unsure, say N. +config CBFS_SIZE + hex + default 0x100000 + help + Reduce CBFS size to give room to the IFD blobs. + endif #INTEL_FIRMWARE |