summaryrefslogtreecommitdiff
path: root/src/southbridge/intel/common
diff options
context:
space:
mode:
authorJoel Kitching <kitching@google.com>2018-09-26 17:58:14 +0800
committerPhilipp Deppenwiese <zaolin.daisuki@gmail.com>2018-10-24 09:07:43 +0000
commit1d93b88af2de9dd3af45ebaffcac4344baaf3d40 (patch)
tree38efffe3368a820814e8c4737499b0544f1ecbd0 /src/southbridge/intel/common
parentc5d0a2ea1fff572d6a61b4c6cb8b3661833f904f (diff)
downloadcoreboot-1d93b88af2de9dd3af45ebaffcac4344baaf3d40.tar.xz
vboot: fix CONFIG_RESUME_PATH_SAME_AS_BOOT S3 resume logic
- should not check VBOOT_STARTS_IN_BOOTBLOCK to set context flag - implement vboot_platform_is_resuming on platforms missing it - add ACPI_INTEL_HARDWARE_SLEEP_VALUES to two intel southbridges [ originally https://review.coreboot.org/c/coreboot/+/28750 ] BUG=b:114018226 TEST=compile coreboot Change-Id: I1ef0bcdfd01746198f8140f49698b58065d820b9 Signed-off-by: Joel Kitching <kitching@google.com> Reviewed-on: https://review.coreboot.org/29060 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Diffstat (limited to 'src/southbridge/intel/common')
-rw-r--r--src/southbridge/intel/common/pmbase.c13
-rw-r--r--src/southbridge/intel/common/pmutil.h2
2 files changed, 15 insertions, 0 deletions
diff --git a/src/southbridge/intel/common/pmbase.c b/src/southbridge/intel/common/pmbase.c
index 360b63d9e4..2de57d6da4 100644
--- a/src/southbridge/intel/common/pmbase.c
+++ b/src/southbridge/intel/common/pmbase.c
@@ -14,13 +14,16 @@
*/
#include <stdint.h>
+#include <arch/acpi.h>
#include <arch/io.h>
#include <device/device.h>
#include <device/pci.h>
#include <arch/early_variables.h>
#include <assert.h>
+#include <security/vboot/vboot_common.h>
#include "pmbase.h"
+#include "pmutil.h"
/* LPC PM Base Address Register */
#define PMBASE 0x40
@@ -91,3 +94,13 @@ u8 read_pmbase8(const u8 addr)
return inb(lpc_get_pmbase() + addr);
}
+
+int vboot_platform_is_resuming(void)
+{
+ u16 reg16 = read_pmbase16(PM1_STS);
+
+ if (!(reg16 & WAK_STS))
+ return 0;
+
+ return acpi_sleep_from_pm1(reg16) == ACPI_S3;
+}
diff --git a/src/southbridge/intel/common/pmutil.h b/src/southbridge/intel/common/pmutil.h
index 273e0f8e9d..26134d9fad 100644
--- a/src/southbridge/intel/common/pmutil.h
+++ b/src/southbridge/intel/common/pmutil.h
@@ -17,6 +17,8 @@
#ifndef INTEL_COMMON_PMUTIL_H
#define INTEL_COMMON_PMUTIL_H
+#include <cpu/x86/smm.h>
+
#define D31F0_PMBASE 0x40
#define D31F0_GEN_PMCON_3 0xa4
#define D31F0_GPIO_ROUT 0xb8