diff options
| author | Konstantin Aladyshev <aladyshev@nicevt.ru> | 2013-03-07 04:04:27 +0400 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-06-11 20:04:03 +0200 |
| commit | 62f8083dfdf0c5e0046efe297b2bf88474928071 (patch) | |
| tree | 68271ade40ed0a7a4a4f492bc9cf5e8f1b5ba509 /src/southbridge/intel/i82801ix | |
| parent | 6e5c86ff7da757687772fc9b1fc3ee41a613684c (diff) | |
| download | coreboot-62f8083dfdf0c5e0046efe297b2bf88474928071.tar.xz | |
Fix cycle error in intel southbridges to display GPI status
Fix obvious mistake in cycle that displays GPI status
I hope i found all duplicates of it.
Change-Id: Ic21ff3ecab85953463e5c23daf808dd5edc82ff8
Signed-off-by: Konstantin Aladyshev <aladyshev@nicevt.ru>
Reviewed-on: http://review.coreboot.org/3435
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/southbridge/intel/i82801ix')
| -rw-r--r-- | src/southbridge/intel/i82801ix/smi.c | 4 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801ix/smihandler.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/southbridge/intel/i82801ix/smi.c b/src/southbridge/intel/i82801ix/smi.c index b0afd1fe87..10c31b163d 100644 --- a/src/southbridge/intel/i82801ix/smi.c +++ b/src/southbridge/intel/i82801ix/smi.c @@ -140,7 +140,7 @@ static void dump_gpe0_status(u64 gpe0_sts) int i; printk(BIOS_DEBUG, "GPE0_STS: "); if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 "); - for (i=31; i<= 16; i--) { + for (i=31; i>= 16; i--) { if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); } if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); @@ -181,7 +181,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts) { int i; printk(BIOS_DEBUG, "ALT_GP_SMI_STS: "); - for (i=15; i<= 0; i--) { + for (i=15; i>= 0; i--) { if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16)); } printk(BIOS_DEBUG, "\n"); diff --git a/src/southbridge/intel/i82801ix/smihandler.c b/src/southbridge/intel/i82801ix/smihandler.c index 913223b0ab..5b6eafaec2 100644 --- a/src/southbridge/intel/i82801ix/smihandler.c +++ b/src/southbridge/intel/i82801ix/smihandler.c @@ -137,7 +137,7 @@ static void dump_gpe0_status(u64 gpe0_sts) int i; printk(BIOS_DEBUG, "GPE0_STS: "); if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 "); - for (i=31; i<= 16; i--) { + for (i=31; i>= 16; i--) { if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); } if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); |