summaryrefslogtreecommitdiff
path: root/src/southbridge/intel/lynxpoint/lpc.c
diff options
context:
space:
mode:
authorRyan Salsamendi <rsalsamendi@hotmail.com>2017-06-30 17:15:57 -0700
committerMartin Roth <martinroth@google.com>2017-07-02 18:54:39 +0000
commit0d9b360b42d39d211d62f0c213aae9e7cf3f2924 (patch)
treeb4e0b236cdade276520d9d92b29fb3efe4c7b442 /src/southbridge/intel/lynxpoint/lpc.c
parent0c731b512a6adf3aa9ecee5e89b6514e75ed6653 (diff)
downloadcoreboot-0d9b360b42d39d211d62f0c213aae9e7cf3f2924.tar.xz
southbridge/intel/lynxpoint: Fix undefined behavior
Fix reports found by undefined behavior sanitizer. Left shifting an int where the right operand is >= the width of the type is undefined. Add UL suffix since it's safe for unsigned types. Change-Id: I755b3c80a8d1b6cb6b6e5f411c6691e5dd17c266 Signed-off-by: Ryan Salsamendi <rsalsamendi@hotmail.com> Reviewed-on: https://review.coreboot.org/20443 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/southbridge/intel/lynxpoint/lpc.c')
-rw-r--r--src/southbridge/intel/lynxpoint/lpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index d295c888f8..6c4acd8c04 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -429,7 +429,7 @@ static void enable_clock_gating(device_t dev)
reg32 = RCBA32(CG);
reg32 |= (1 << 22); // HDA Dynamic
- reg32 |= (1 << 31); // LPC Dynamic
+ reg32 |= (1UL << 31); // LPC Dynamic
reg32 |= (1 << 16); // PCIe Dynamic
reg32 |= (1 << 27); // HPET Dynamic
reg32 |= (1 << 28); // GPIO Dynamic