diff options
| author | Ryan Salsamendi <rsalsamendi@hotmail.com> | 2017-06-30 17:15:57 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-07-02 18:54:39 +0000 |
| commit | 0d9b360b42d39d211d62f0c213aae9e7cf3f2924 (patch) | |
| tree | b4e0b236cdade276520d9d92b29fb3efe4c7b442 /src/southbridge/intel/lynxpoint/pmutil.c | |
| parent | 0c731b512a6adf3aa9ecee5e89b6514e75ed6653 (diff) | |
| download | coreboot-0d9b360b42d39d211d62f0c213aae9e7cf3f2924.tar.xz | |
southbridge/intel/lynxpoint: Fix undefined behavior
Fix reports found by undefined behavior sanitizer. Left shifting an int
where the right operand is >= the width of the type is undefined. Add
UL suffix since it's safe for unsigned types.
Change-Id: I755b3c80a8d1b6cb6b6e5f411c6691e5dd17c266
Signed-off-by: Ryan Salsamendi <rsalsamendi@hotmail.com>
Reviewed-on: https://review.coreboot.org/20443
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/southbridge/intel/lynxpoint/pmutil.c')
| -rw-r--r-- | src/southbridge/intel/lynxpoint/pmutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/southbridge/intel/lynxpoint/pmutil.c b/src/southbridge/intel/lynxpoint/pmutil.c index 90045d1be0..d895c56df1 100644 --- a/src/southbridge/intel/lynxpoint/pmutil.c +++ b/src/southbridge/intel/lynxpoint/pmutil.c @@ -45,7 +45,7 @@ static void print_status_bits(u32 status, const char *bit_names[]) return; for (i=31; i>=0; i--) { - if (status & (1 << i)) { + if (status & (1UL << i)) { if (bit_names[i]) printk(BIOS_DEBUG, "%s ", bit_names[i]); else |