summaryrefslogtreecommitdiff
path: root/src/southbridge/intel/lynxpoint
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-06-02 05:05:30 +0300
committerPatrick Georgi <pgeorgi@google.com>2020-06-16 08:02:54 +0000
commitad882c3b171ccd71d84ddc971ab0c4ae563190de (patch)
treef2f5df34b60fc1ba767370adbd2a8cb564752138 /src/southbridge/intel/lynxpoint
parentb6585481e8cb30ed04a1673b170af3df9e0e4320 (diff)
downloadcoreboot-ad882c3b171ccd71d84ddc971ab0c4ae563190de.tar.xz
sb/intel: Remove spurious HAVE_SMI_HANDLER test
There are no side-effects in calling acpi_is_wakeup_s3() and apm_control() is a no-op with HAVE_SMI_HANDLER=n. Change-Id: Ia9195781955cc5fa96d0690aa7735fc590e527e4 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41986 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge/intel/lynxpoint')
-rw-r--r--src/southbridge/intel/lynxpoint/lpc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index bf03125a8a..6cdbc78212 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -473,9 +473,8 @@ static void enable_lp_clock_gating(struct device *dev)
static void pch_set_acpi_mode(void)
{
- if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) {
+ if (!acpi_is_wakeup_s3())
apm_control(APM_CNT_ACPI_DISABLE);
- }
}
static void pch_disable_smm_only_flashing(struct device *dev)