summaryrefslogtreecommitdiff
path: root/src/southbridge/intel
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@chromium.org>2013-08-08 15:40:01 -0700
committerPatrick Georgi <patrick@georgi-clan.de>2013-12-21 12:02:31 +0100
commit0b3cd36061d853a470f38415f71ca78bb3f9d331 (patch)
tree78f6cbf9fd07278e7b7e62c84ee6cef1b4af1806 /src/southbridge/intel
parentc45dc1c08131dfaf5f8a26927b40006660c1ebf6 (diff)
downloadcoreboot-0b3cd36061d853a470f38415f71ca78bb3f9d331.tar.xz
lynxpoint: me: Disable some verbose messages
The default ME output is quite verbose and not all that useful unless you are actively debugging the ME and then you can enable the CONFIG_DEBUG_INTEL_ME option. This commit silences the firmware capabilities and the MBP output. Change-Id: I2b8abcb34ae0d00d9a38d029979e84ee0d0ca287 Signed-off-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/65252 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/4452 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/southbridge/intel')
-rw-r--r--src/southbridge/intel/lynxpoint/me_9.x.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c
index e01316f28e..d3dfcfb152 100644
--- a/src/southbridge/intel/lynxpoint/me_9.x.c
+++ b/src/southbridge/intel/lynxpoint/me_9.x.c
@@ -496,6 +496,7 @@ static void me_print_fw_version(mbp_fw_version_name *vers_name)
vers_name->hotfix_version, vers_name->build_version);
}
+#if CONFIG_DEBUG_INTEL_ME
/* Get ME Firmware Capabilities */
static int mkhi_get_fwcaps(mbp_mefwcaps *cap)
{
@@ -543,6 +544,7 @@ static void me_print_fwcaps(mbp_mefwcaps *cap)
print_cap("Wireless LAN (WLAN)", cap->wlan);
}
#endif
+#endif
#if CONFIG_CHROMEOS && 0 /* DISABLED */
/* Tell ME to issue a global reset */
@@ -836,7 +838,9 @@ static void intel_me_init(device_t dev)
#if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG)
me_print_fw_version(mbp_data.fw_version_name);
+#if CONFIG_DEBUG_INTEL_ME
me_print_fwcaps(mbp_data.fw_capabilities);
+#endif
if (mbp_data.plat_time) {
printk(BIOS_DEBUG, "ME: Wake Event to ME Reset: %u ms\n",
@@ -1001,10 +1005,12 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
#if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG)
printk(BIOS_INFO, "ME MBP: Header: items: %d, size dw: %d\n",
mbp->header.num_entries, mbp->header.mbp_size);
+#if CONFIG_DEBUG_INTEL_ME
for (i = 0; i < mbp->header.mbp_size - 1; i++) {
printk(BIOS_INFO, "ME MBP: %04x: 0x%08x\n", i, mbp->data[i]);
}
#endif
+#endif
#define ASSIGN_FIELD_PTR(field_,val_) \
{ \
@@ -1047,8 +1053,8 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
ASSIGN_FIELD_PTR(nfc_data, &mbp->data[i+1]);
default:
- printk(BIOS_ERR, "ME MBP: unknown item 0x%x @ dw offset 0x%x\n",
- mbp->data[i], i);
+ printk(BIOS_ERR, "ME MBP: unknown item 0x%x @ "
+ "dw offset 0x%x\n", mbp->data[i], i);
break;
}
i += item->length;