diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-03-19 15:13:46 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-22 11:26:22 +0000 |
| commit | 88f94a9635cd64aaf6eeb3ed3991dceabcf6387a (patch) | |
| tree | fef34198fe0464e964e985d4889f9df747bd66b9 /src/southbridge/intel | |
| parent | d12d24b03930665be9ed9a16875577a770e6d7db (diff) | |
| download | coreboot-88f94a9635cd64aaf6eeb3ed3991dceabcf6387a.tar.xz | |
lynxpoint/broadwell: Rename LP GPIO config global
Do not use the same name as the non-LP GPIO config. This allows checking
at build-time that a mainboard uses the correct GPIO config format.
Without this commit, there are no build-time errors when using the wrong
format of GPIO config, but there would be undefined behavior at runtime.
Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after
toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the
USB config arrays for asrock/b85m_pro4). In both cases, building failed
because the necessary GPIO config global is not defined, as expected.
Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge/intel')
| -rw-r--r-- | src/southbridge/intel/lynxpoint/early_pch.c | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/lynxpoint/lp_gpio.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/southbridge/intel/lynxpoint/early_pch.c b/src/southbridge/intel/lynxpoint/early_pch.c index 66a3205c3b..03823ff196 100644 --- a/src/southbridge/intel/lynxpoint/early_pch.c +++ b/src/southbridge/intel/lynxpoint/early_pch.c @@ -90,7 +90,7 @@ void early_pch_init(void) pch_enable_bars(); #if CONFIG(INTEL_LYNXPOINT_LP) - setup_pch_lp_gpios(mainboard_gpio_map); + setup_pch_lp_gpios(mainboard_lp_gpio_map); #else setup_pch_gpios(&mainboard_gpio_map); #endif diff --git a/src/southbridge/intel/lynxpoint/lp_gpio.h b/src/southbridge/intel/lynxpoint/lp_gpio.h index e7f692d7f4..fc40c3ddcc 100644 --- a/src/southbridge/intel/lynxpoint/lp_gpio.h +++ b/src/southbridge/intel/lynxpoint/lp_gpio.h @@ -172,6 +172,6 @@ int gpio_is_native(int gpio_num); */ unsigned int get_gpios(const int *gpio_num_array); -extern const struct pch_lp_gpio_map mainboard_gpio_map[]; +extern const struct pch_lp_gpio_map mainboard_lp_gpio_map[]; #endif |