diff options
author | Elyes HAOUAS <ehaouas@noos.fr> | 2019-03-01 10:45:44 +0100 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-03-04 13:57:45 +0000 |
commit | 2796b242b20ca4276f64d09ddabc3ee4c5a81148 (patch) | |
tree | d32d368a73afd34f1ac73021163acd11d72fb0af /src/southbridge/intel | |
parent | ee69f73dbf1934db7a45088eb3ad1d8b110cbb92 (diff) | |
download | coreboot-2796b242b20ca4276f64d09ddabc3ee4c5a81148.tar.xz |
nb/intel/i945: Remove redundant use of ACPI offset operator
IASL version 20180927 and greater, detects Unnecessary/redundant uses of
the Offset() operator within a Field Unit list.
It then sends a remark "^ Unnecessary/redundant use of Offset"
example:
OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
Field (OPR1)
{
Offset (0), // Never needed
FLD1, 32,
Offset (4), // Redundant, offset is already 4 (bytes)
FLD2, 8,
Offset (64), // OK use of Offset.
FLD3, 16,
}
We will have those remarks:
dsdt.asl 14: Offset (0),
Remark 2158 - ^ Unnecessary/redundant use of Offset
operator
dsdt.asl 16: Offset (4),
Remark 2158 - ^ Unnecessary/redundant use of Offset
operator
Change-Id: Ie1f2a2ace335af7984209c9e286b9f85e5342a7e
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/31671
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/southbridge/intel')
0 files changed, 0 insertions, 0 deletions