diff options
| author | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-27 11:32:38 -0800 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-28 07:57:17 +0100 |
| commit | 5079a0d32f2824445cf593dfbcb65598eaa97dee (patch) | |
| tree | 2e6edd336c00f1f3e4937410a9be9537553702be /src/southbridge/nvidia | |
| parent | acf443191bd035c26ee89c3ca56f065a5111901b (diff) | |
| download | coreboot-5079a0d32f2824445cf593dfbcb65598eaa97dee.tar.xz | |
Remove assembly coded log2 function
As we move to supporting other systems we need to get rid of assembly
where we can. The log2 function in src/lib is identical to the assembly
one (tested for all 32-bit signed integers :-) and takes about 10 ns
to run as opposed to 5ns for the non-portable assembly version. While speed
is good, I think we can spare the 15 ns or so we add to boot time
by using the C version only.
Change-Id: Icafa565eae282c85fa5fc01b3bd1f110cd9aaa91
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: http://review.coreboot.org/1928
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/southbridge/nvidia')
| -rw-r--r-- | src/southbridge/nvidia/ck804/lpc.c | 1 | ||||
| -rw-r--r-- | src/southbridge/nvidia/ck804/smbus.c | 1 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/lpc.c | 1 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/smbus.c | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/src/southbridge/nvidia/ck804/lpc.c b/src/southbridge/nvidia/ck804/lpc.c index d37188265f..6ccea6a354 100644 --- a/src/southbridge/nvidia/ck804/lpc.c +++ b/src/southbridge/nvidia/ck804/lpc.c @@ -28,7 +28,6 @@ #include <device/pci_ops.h> #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> -#include <bitops.h> #include <arch/io.h> #include <arch/ioapic.h> #include <cpu/x86/lapic.h> diff --git a/src/southbridge/nvidia/ck804/smbus.c b/src/southbridge/nvidia/ck804/smbus.c index 011faf8fb4..269340eb91 100644 --- a/src/southbridge/nvidia/ck804/smbus.c +++ b/src/southbridge/nvidia/ck804/smbus.c @@ -24,7 +24,6 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/smbus.h> -#include <bitops.h> #include <arch/io.h> #include "ck804.h" #include "smbus.h" diff --git a/src/southbridge/nvidia/mcp55/lpc.c b/src/southbridge/nvidia/mcp55/lpc.c index d16e3cc509..1e2155ae73 100644 --- a/src/southbridge/nvidia/mcp55/lpc.c +++ b/src/southbridge/nvidia/mcp55/lpc.c @@ -31,7 +31,6 @@ #include <device/pci_ops.h> #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> -#include <bitops.h> #include <arch/io.h> #include <arch/ioapic.h> #include <cpu/x86/lapic.h> diff --git a/src/southbridge/nvidia/mcp55/smbus.c b/src/southbridge/nvidia/mcp55/smbus.c index a945f237d0..694918630b 100644 --- a/src/southbridge/nvidia/mcp55/smbus.c +++ b/src/southbridge/nvidia/mcp55/smbus.c @@ -27,7 +27,6 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/smbus.h> -#include <bitops.h> #include <arch/io.h> #include "mcp55.h" #include "smbus.h" |