diff options
| author | Stefan Reinauer <stepan@coresystems.de> | 2010-04-09 14:46:51 +0000 |
|---|---|---|
| committer | Stefan Reinauer <stepan@openbios.org> | 2010-04-09 14:46:51 +0000 |
| commit | d4f53738e678f99bd12068b2e2b2ecae9fc046b0 (patch) | |
| tree | 0f15a41041822a88cef4fb74fa747b0021ac8960 /src/southbridge/nvidia | |
| parent | f358c0c55510e4272ace99e192b9494e64f89697 (diff) | |
| download | coreboot-d4f53738e678f99bd12068b2e2b2ecae9fc046b0.tar.xz | |
zero warnings days.
The tyan s2895 is down to 3 warnings, 2 of which are caused by #warning.
The 1000 ways of how the AMD code waits for the cores to be started up
are a real pain for the brain.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5396 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/nvidia')
| -rw-r--r-- | src/southbridge/nvidia/ck804/ck804_early_smbus.c | 2 | ||||
| -rw-r--r-- | src/southbridge/nvidia/ck804/ck804_smbus.h | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/southbridge/nvidia/ck804/ck804_early_smbus.c b/src/southbridge/nvidia/ck804/ck804_early_smbus.c index db641415ff..2b59a77988 100644 --- a/src/southbridge/nvidia/ck804/ck804_early_smbus.c +++ b/src/southbridge/nvidia/ck804/ck804_early_smbus.c @@ -31,7 +31,7 @@ static int smbus_read_byte(unsigned device, unsigned address) return do_smbus_read_byte(SMBUS_IO_BASE, device, address); } -static int smbus_write_byte(unsigned device, unsigned address, +static inline int smbus_write_byte(unsigned device, unsigned address, unsigned char val) { return do_smbus_write_byte(SMBUS_IO_BASE, device, address, val); diff --git a/src/southbridge/nvidia/ck804/ck804_smbus.h b/src/southbridge/nvidia/ck804/ck804_smbus.h index 8067ffb9a5..bd34dc3aa5 100644 --- a/src/southbridge/nvidia/ck804/ck804_smbus.h +++ b/src/southbridge/nvidia/ck804/ck804_smbus.h @@ -23,6 +23,8 @@ static inline void smbus_delay(void) outb(0x80, 0x80); } +#if 0 +/* Not needed, upon write to PRTCL, the status will be auto-cleared. */ static int smbus_wait_until_ready(unsigned smbus_io_base) { unsigned long loops; @@ -38,6 +40,7 @@ static int smbus_wait_until_ready(unsigned smbus_io_base) } while (--loops); return -2; } +#endif static int smbus_wait_until_done(unsigned smbus_io_base) { @@ -53,6 +56,7 @@ static int smbus_wait_until_done(unsigned smbus_io_base) return -3; } +#ifndef __PRE_RAM__ static int do_smbus_recv_byte(unsigned smbus_io_base, unsigned device) { unsigned char global_status_register, byte; @@ -129,6 +133,7 @@ static int do_smbus_send_byte(unsigned smbus_io_base, unsigned device, return 0; } +#endif static int do_smbus_read_byte(unsigned smbus_io_base, unsigned device, unsigned address) |