diff options
| author | Julius Werner <jwerner@chromium.org> | 2017-05-18 16:03:26 -0700 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2017-06-13 20:53:09 +0200 |
| commit | 01f9aa5e54cf55ecca1b35185373835e61f10615 (patch) | |
| tree | 8cd1ecb517bd948ac2dc2616de789a84a999a911 /src/southbridge/sis | |
| parent | d9762f70acc1cc2db5b3905756f5f5a995b9a21a (diff) | |
| download | coreboot-01f9aa5e54cf55ecca1b35185373835e61f10615.tar.xz | |
Consolidate reset API, add generic reset_prepare mechanism
There are many good reasons why we may want to run some sort of generic
callback before we're executing a reset. Unfortunateley, that is really
hard right now: code that wants to reset simply calls the hard_reset()
function (or one of its ill-differentiated cousins) which is directly
implemented by a myriad of different mainboards, northbridges, SoCs,
etc. More recent x86 SoCs have tried to solve the problem in their own
little corner of soc/intel/common, but it's really something that would
benefit all of coreboot.
This patch expands the concept onto all boards: hard_reset() and friends
get implemented in a generic location where they can run hooks before
calling the platform-specific implementation that is now called
do_hard_reset(). The existing Intel reset_prepare() gets generalized as
soc_reset_prepare() (and other hooks for arch, mainboard, etc. can now
easily be added later if necessary). We will also use this central point
to ensure all platforms flush their cache before reset, which is
generally useful for all cases where we're trying to persist information
in RAM across reboots (like the new persistent CBMEM console does).
Also remove cpu_reset() completely since it's not used anywhere and
doesn't seem very useful compared to the others.
Change-Id: I41b89ce4a923102f0748922496e1dd9bce8a610f
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/19789
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/southbridge/sis')
| -rw-r--r-- | src/southbridge/sis/sis966/early_ctrl.c | 4 | ||||
| -rw-r--r-- | src/southbridge/sis/sis966/reset.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/southbridge/sis/sis966/early_ctrl.c b/src/southbridge/sis/sis966/early_ctrl.c index 74ae1fa05a..4fb2d9d11b 100644 --- a/src/southbridge/sis/sis966/early_ctrl.c +++ b/src/southbridge/sis/sis966/early_ctrl.c @@ -29,7 +29,7 @@ static unsigned get_sbdn(unsigned bus) return (dev>>15) & 0x1f; } -void hard_reset(void) +void do_hard_reset(void) { set_bios_reset(); @@ -44,7 +44,7 @@ static void enable_fid_change_on_sb(unsigned sbbusn, unsigned sbdn) /* set VFSMAF ( VID/FID System Management Action Field) to 2 */ } -void soft_reset(void) +void do_soft_reset(void) { set_bios_reset(); diff --git a/src/southbridge/sis/sis966/reset.c b/src/southbridge/sis/sis966/reset.c index a381cd31a9..7be98d7a2f 100644 --- a/src/southbridge/sis/sis966/reset.c +++ b/src/southbridge/sis/sis966/reset.c @@ -24,7 +24,7 @@ #include "../../../northbridge/amd/amdk8/reset_test.c" -void hard_reset(void) +void do_hard_reset(void) { set_bios_reset(); /* Try rebooting through port 0xcf9 */ |