diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2007-11-15 15:52:42 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2007-11-15 15:52:42 +0000 |
| commit | 70ab323ae61567a005058f6e7bdd1f6990e6e7fd (patch) | |
| tree | d91d14376cc38436f3b51073737cce75b47262b9 /src/southbridge/via/k8t890/k8t890_traf_ctrl.c | |
| parent | e13abe53b49fdd61fcf56bc21b578057c5f1c72f (diff) | |
| download | coreboot-70ab323ae61567a005058f6e7bdd1f6990e6e7fd.tar.xz | |
Various cosmetic fixes and improvements (trivial).
- Use 'static' where appropriate.
- Use 'const' where appropriate.
- Indentation fixes.
- Add comment wrt init code which is only valid for VT8237R.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2974 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/via/k8t890/k8t890_traf_ctrl.c')
| -rw-r--r-- | src/southbridge/via/k8t890/k8t890_traf_ctrl.c | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/src/southbridge/via/k8t890/k8t890_traf_ctrl.c b/src/southbridge/via/k8t890/k8t890_traf_ctrl.c index 85ab5a0551..304dfaea7f 100644 --- a/src/southbridge/via/k8t890/k8t890_traf_ctrl.c +++ b/src/southbridge/via/k8t890/k8t890_traf_ctrl.c @@ -19,13 +19,11 @@ #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> #include <console/console.h> - #include "k8t890.h" -void mmconfig_set_resources(device_t dev) +static void mmconfig_set_resources(device_t dev) { struct resource *resource; u8 reg; @@ -106,16 +104,16 @@ static void traf_ctrl_enable(struct device *dev) apic[4] = (data & 0xF0FFFF) | (K8T890_APIC_ID << 24); } -static struct device_operations traf_ctrl_ops = { - .read_resources = apic_mmconfig_read_resources, - .set_resources = mmconfig_set_resources, - .enable_resources = pci_dev_enable_resources, - .enable = traf_ctrl_enable, - .ops_pci = 0, +static const struct device_operations traf_ctrl_ops = { + .read_resources = apic_mmconfig_read_resources, + .set_resources = mmconfig_set_resources, + .enable_resources = pci_dev_enable_resources, + .enable = traf_ctrl_enable, + .ops_pci = 0, }; static const struct pci_driver northbridge_driver __pci_driver = { - .ops = &traf_ctrl_ops, - .vendor = PCI_VENDOR_ID_VIA, - .device = PCI_DEVICE_ID_VIA_K8T890CE_5, + .ops = &traf_ctrl_ops, + .vendor = PCI_VENDOR_ID_VIA, + .device = PCI_DEVICE_ID_VIA_K8T890CE_5, }; |