summaryrefslogtreecommitdiff
path: root/src/southbridge/via/vt8235
diff options
context:
space:
mode:
authorStefan Reinauer <stepan@coresystems.de>2010-04-15 12:39:29 +0000
committerStefan Reinauer <stepan@openbios.org>2010-04-15 12:39:29 +0000
commit23836e2345282151b0b46de6cdcd2bb2faee87f6 (patch)
treee1e416ae11a78b455a26f378f33d0a8db6fa69af /src/southbridge/via/vt8235
parentc30a6e859e20dbadbad006f2f93068e7f9c36043 (diff)
downloadcoreboot-23836e2345282151b0b46de6cdcd2bb2faee87f6.tar.xz
zero warnings days...
Signed-off-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5442 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/via/vt8235')
-rw-r--r--src/southbridge/via/vt8235/vt8235.c36
1 files changed, 17 insertions, 19 deletions
diff --git a/src/southbridge/via/vt8235/vt8235.c b/src/southbridge/via/vt8235/vt8235.c
index 92bd9d8391..747c2157f1 100644
--- a/src/southbridge/via/vt8235/vt8235.c
+++ b/src/southbridge/via/vt8235/vt8235.c
@@ -7,18 +7,9 @@
#include <pc80/i8259.h>
#include "chip.h"
-/*
- * Base VT8235.
- */
-
-void hard_reset(void)
-{
- printk(BIOS_ERR, "NO HARD RESET ON VT8235! FIX ME!\n");
-}
-
static void keyboard_on(struct device *dev)
{
- unsigned char regval;
+ u8 regval;
regval = pci_read_config8(dev, 0x51);
regval |= 0x05;
@@ -28,6 +19,7 @@ static void keyboard_on(struct device *dev)
pc_keyboard_init(0);
}
+#ifdef UNUSED_CODE
void dump_south(device_t dev0)
{
int i,j;
@@ -43,33 +35,37 @@ void dump_south(device_t dev0)
void set_led(void)
{
- // set power led to steady now that lxbios has virtually done its job
+ // set power led to steady now that coreboot has virtually done its job
device_t dev;
dev = dev_find_device(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8235, 0);
pci_write_config8(dev, 0x94, 0xb0);
}
-
+#endif
static void vt8235_enable(struct device *dev)
{
- unsigned char regval;
- unsigned short vendor,model;
+ u8 regval;
+ u16 vendor,model;
vendor = pci_read_config16(dev,0);
model = pci_read_config16(dev,0x2);
printk(BIOS_DEBUG, "In vt8235_enable %04x %04x.\n",vendor,model);
- /* if this is not the southbridge itself just return */
- /* this is necessary because USB devices are slot 10, whereas this device is slot 11
- therefore usb devices get called first during the bus scan */
+ /* If this is not the southbridge itself just return.
+ * This is necessary because USB devices are slot 10, whereas this
+ * device is slot 11 therefore usb devices get called first during
+ * the bus scan. We don't want to wait until we could do dev->init
+ * because that's too late.
+ */
if( (vendor != PCI_VENDOR_ID_VIA) || (model != PCI_DEVICE_ID_VIA_8235))
return;
printk(BIOS_DEBUG, "Initialising Devices\n");
- setup_i8259(); // make sure interupt controller is configured before keyboard init
+ /* make sure interupt controller is configured before keyboard init */
+ setup_i8259();
/* enable RTC and ethernet */
regval = pci_read_config8(dev, 0x51);
@@ -79,7 +75,9 @@ static void vt8235_enable(struct device *dev)
/* turn on keyboard */
keyboard_on(dev);
- /* enable USB 1.1 & USB 2.0 -redundant really since we've already been there - see note above*/
+ /* enable USB 1.1 & USB 2.0 - redundant really since we've
+ * already been there - see note above
+ */
regval = pci_read_config8(dev, 0x50);
regval &= ~(0x36);
pci_write_config8(dev, 0x50, regval);