Drop VIA VT8235 southbridge

It's unused.

Change-Id: Iad3e7aa0f777392c9d65b9fcdd3c1666af31723a
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/7883
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>

13 files changed, 77 insertions, 933 deletions

diff --git a/src/southbridge/via/Kconfig b/src/southbridge/via/Kconfig
index 641c2a4ae5..75a1395e8a 100644
--- a/src/southbridge/via/Kconfig
+++ b/src/southbridge/via/Kconfig
@@ -1,3 +1,2 @@
 source src/southbridge/via/k8t890/Kconfig
-source src/southbridge/via/vt8235/Kconfig
 source src/southbridge/via/vt8237r/Kconfig
diff --git a/src/southbridge/via/Makefile.inc b/src/southbridge/via/Makefile.inc
index 1c239b1f67..db19438005 100644
--- a/src/southbridge/via/Makefile.inc
+++ b/src/southbridge/via/Makefile.inc
@@ -1,3 +1,2 @@
 subdirs-$(CONFIG_SOUTHBRIDGE_VIA_K8T890) += k8t890
-subdirs-$(CONFIG_SOUTHBRIDGE_VIA_VT8235) += vt8235
 subdirs-$(CONFIG_SOUTHBRIDGE_VIA_VT8237R) += vt8237r
diff --git a/src/southbridge/via/vt8235/Kconfig b/src/southbridge/via/vt8235/Kconfig
deleted file mode 100644
index 1591274858..0000000000
--- a/src/southbridge/via/vt8235/Kconfig
+++ /dev/null
@@ -1,22 +0,0 @@
-##
-## This file is part of the coreboot project.
-##
-## Copyright (C) 2008-2009 coresystems GmbH
-##
-## This program is free software; you can redistribute it and/or modify
-## it under the terms of the GNU General Public License as published by
-## the Free Software Foundation; version 2 of the License.
-##
-## This program is distributed in the hope that it will be useful,
-## but WITHOUT ANY WARRANTY; without even the implied warranty of
-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-## GNU General Public License for more details.
-##
-## You should have received a copy of the GNU General Public License
-## along with this program; if not, write to the Free Software
-## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-##
-
-config SOUTHBRIDGE_VIA_VT8235
-	bool
-
diff --git a/src/southbridge/via/vt8235/Makefile.inc b/src/southbridge/via/vt8235/Makefile.inc
deleted file mode 100644
index 5c1068e8e4..0000000000
--- a/src/southbridge/via/vt8235/Makefile.inc
+++ /dev/null
@@ -1,24 +0,0 @@
-##
-## This file is part of the coreboot project.
-##
-## Copyright (C) 2007, 2009 Rudolf Marek <r.marek@assembler.cz>
-##
-## This program is free software; you can redistribute it and/or modify
-## it under the terms of the GNU General Public License as published by
-## the Free Software Foundation; version 2 of the License.
-##
-## This program is distributed in the hope that it will be useful,
-## but WITHOUT ANY WARRANTY; without even the implied warranty of
-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-## GNU General Public License for more details.
-##
-## You should have received a copy of the GNU General Public License
-## along with this program; if not, write to the Free Software
-## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-##
-
-ramstage-y += vt8235.c
-ramstage-y += ide.c
-ramstage-y += lpc.c
-ramstage-y += nic.c
-ramstage-y += usb.c
diff --git a/src/southbridge/via/vt8235/chip.h b/src/southbridge/via/vt8235/chip.h
deleted file mode 100644
index eb1e82b7c8..0000000000
--- a/src/southbridge/via/vt8235/chip.h
+++ /dev/null
@@ -1,19 +0,0 @@
-#ifndef _SOUTHBRIDGE_VIA_VT8235
-#define _SOUTHBRIDGE_VIA_VT8235
-
-struct southbridge_via_vt8235_config {
-	/* PCI function enables */
-	/* i.e. so that pci scan bus will find them. */
-	/* I am putting in IDE as an example but obviously this needs
-	 * to be more complete!
-	 */
-	int enable_ide;
-	/* enables of functions of devices */
-	int enable_usb;
-	int enable_native_ide;
-	int enable_com_ports;
-	int enable_keyboard;
-	int enable_nvram;
-};
-
-#endif /* _SOUTHBRIDGE_VIA_VT8235 */
diff --git a/src/southbridge/via/vt8235/early_serial.c b/src/southbridge/via/vt8235/early_serial.c
deleted file mode 100644
index b9bec5fa08..0000000000
--- a/src/southbridge/via/vt8235/early_serial.c
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- * Enable the serial devices on the VIA
- */
-
-
-/* The base address is 0x15c, 0x2e, depending on config bytes */
-
-#define SIO_BASE 0x3f0
-#define SIO_DATA  SIO_BASE+1
-
-static void vt8235_writepnpaddr(uint8_t val)
-{
-	outb(val, 0x2e);
-	outb(val, 0xeb);
-}
-
-static void vt8235_writepnpdata(uint8_t val)
-{
-	outb(val, 0x2f);
-	outb(val, 0xeb);
-}
-
-
-static void vt8235_writesiobyte(uint16_t reg, uint8_t val)
-{
-	outb(val, reg);
-}
-
-static void vt8235_writesioword(uint16_t reg, uint16_t val)
-{
-	outw(val, reg);
-}
-
-
-/* regs we use: 85, and the southbridge devfn is defined by the
-   mainboard
- */
-
-static void enable_vt8235_serial(void)
-{
-	// turn on pnp
-	vt8235_writepnpaddr(0x87);
-	vt8235_writepnpaddr(0x87);
-	// now go ahead and set up com1.
-	// set address
-	vt8235_writepnpaddr(0x7);
-	vt8235_writepnpdata(0x2);
-	// enable serial out
-	vt8235_writepnpaddr(0x30);
-	vt8235_writepnpdata(0x1);
-	// serial port 1 base address (FEh)
-	vt8235_writepnpaddr(0x60);
-	vt8235_writepnpdata(0xfe);
-	// serial port 1 IRQ (04h)
-	vt8235_writepnpaddr(0x70);
-	vt8235_writepnpdata(0x4);
-	// serial port 1 control
-	vt8235_writepnpaddr(0xf0);
-	vt8235_writepnpdata(0x2);
-	// turn of pnp
-	vt8235_writepnpaddr(0xaa);
-
-	// set up reg to set baud rate.
-	vt8235_writesiobyte(0x3fb, 0x80);
-	// Set 115 kb
-	vt8235_writesioword(0x3f8, 1);
-	// Set 9.6 kb
-	//	WRITESIOWORD(0x3f8, 12)
-	// now set no parity, one stop, 8 bits
-	vt8235_writesiobyte(0x3fb, 3);
-	// now turn on RTS, DRT
-	vt8235_writesiobyte(0x3fc, 3);
-	// Enable interrupts
-	vt8235_writesiobyte(0x3f9, 0xf);
-	// should be done. Dump a char for fun.
-	vt8235_writesiobyte(0x3f8, 48);
-}
diff --git a/src/southbridge/via/vt8235/early_smbus.c b/src/southbridge/via/vt8235/early_smbus.c
deleted file mode 100644
index c4bca9c210..0000000000
--- a/src/southbridge/via/vt8235/early_smbus.c
+++ /dev/null
@@ -1,247 +0,0 @@
-#define SMBUS_IO_BASE	0xf00
-
-#define SMBHSTSTAT	0x0
-#define SMBSLVSTAT	0x1
-#define SMBHSTCTL	0x2
-#define SMBHSTCMD	0x3
-#define SMBXMITADD	0x4
-#define SMBHSTDAT0	0x5
-#define SMBHSTDAT1	0x6
-#define SMBBLKDAT	0x7
-#define SMBSLVCTL	0x8
-#define SMBTRNSADD	0x9
-#define SMBSLVDATA	0xa
-#define SMLINK_PIN_CTL	0xe
-#define SMBUS_PIN_CTL	0xf
-
-/* Define register settings */
-#define HOST_RESET 0xff
-#define READ_CMD  0x01        // 1 in the 0 bit of SMBHSTADD states to READ
-
-
-#define SMBUS_TIMEOUT (100*1000*10)
-
-#define I2C_TRANS_CMD		0x40
-#define CLOCK_SLAVE_ADDRESS	0x69
-
-static void enable_smbus(void)
-{
-	device_t dev;
-	unsigned char c;
-	int i;
-
-	/* Power management controller */
-	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA,
-				PCI_DEVICE_ID_VIA_8235), 0);
-
-	if (dev == PCI_DEV_INVALID) {
-		die("SMBUS controller not found\n");
-	}
-
-	// set IO base address to SMBUS_IO_BASE
-	pci_write_config16(dev, 0xd0, SMBUS_IO_BASE | 1);
-
-	// Enable SMBus
-	pci_write_config8(dev, 0xd2, (0x4 << 1) | 1);
-
-	/* make it work for I/O ...
-	 */
-	pci_write_config16(dev, 4, 1);
-
-	/* FIX for half baud rate problem */
-	/* let clocks and the like settle */
-	/* as yet arbitrary count - 1000 is too little 5000 works */
-	for(i = 0 ; i < 5000 ; i++)
-		outb(0x80,0x80);
-
-	/*
-	 * The VT1211 serial port needs 48 mhz clock, on power up it is getting
-	 *  only 24 mhz, there is some mysterious device on the smbus that can
-	 *  fix this...this code below does it.
-	 *  */
-	outb(0xff, SMBUS_IO_BASE+SMBHSTSTAT);
-	outb(0x7f, SMBUS_IO_BASE+SMBHSTDAT0);
-	outb(0x83, SMBUS_IO_BASE+SMBHSTCMD);
-	outb(CLOCK_SLAVE_ADDRESS<<1 , SMBUS_IO_BASE+SMBXMITADD);
-	outb(8 | I2C_TRANS_CMD, SMBUS_IO_BASE+SMBHSTCTL);
-
-	for (;;) {
-		c = inb(SMBUS_IO_BASE+SMBHSTSTAT);
-		if ((c & 1) == 0)
-			break;
-	}
-}
-
-
-static inline void smbus_delay(void)
-{
-	outb(0x80, 0x80);
-}
-
-static int smbus_wait_until_ready(void)
-{
-	unsigned char c;
-	unsigned long loops;
-	loops = SMBUS_TIMEOUT;
-	do {
-		smbus_delay();
-		c = inb(SMBUS_IO_BASE + SMBHSTSTAT);
-		while((c & 1) == 1) {
-			print_debug("c is ");
-			print_debug_hex8(c);
-			print_debug("\n");
-			c = inb(SMBUS_IO_BASE + SMBHSTSTAT);
-			/* nop */
-		}
-
-	} while(--loops);
-	return loops?0:-1;
-}
-
-void smbus_reset(void)
-{
-	outb(HOST_RESET, SMBUS_IO_BASE + SMBHSTSTAT);
-	outb(HOST_RESET, SMBUS_IO_BASE + SMBHSTSTAT);
-	outb(HOST_RESET, SMBUS_IO_BASE + SMBHSTSTAT);
-	outb(HOST_RESET, SMBUS_IO_BASE + SMBHSTSTAT);
-
-	smbus_wait_until_ready();
-	print_debug("After reset status ");
-	print_debug_hex8( inb(SMBUS_IO_BASE + SMBHSTSTAT));
-	print_debug("\n");
-}
-
-
-
-static int smbus_wait_until_done(void)
-{
-	unsigned long loops;
-	unsigned char byte;
-	loops = SMBUS_TIMEOUT;
-	do {
-		smbus_delay();
-
-		byte = inb(SMBUS_IO_BASE + SMBHSTSTAT);
-		if (byte & 1)
-			break;
-
-	} while(--loops);
-	return loops?0:-1;
-}
-
-static void smbus_print_error(unsigned char host_status_register)
-{
-
-	print_err("smbus_error: ");
-	print_err_hex8(host_status_register);
-	print_err("\n");
-	if (host_status_register & (1 << 4)) {
-		print_err("Interrupt/SMI# was Failed Bus Transaction\n");
-	}
-	if (host_status_register & (1 << 3)) {
-		print_err("Bus Error\n");
-	}
-	if (host_status_register & (1 << 2)) {
-		print_err("Device Error\n");
-	}
-	if (host_status_register & (1 << 1)) {
-		print_err("Interrupt/SMI# was Successful Completion\n");
-	}
-	if (host_status_register & (1 << 0)) {
-		print_err("Host Busy\n");
-	}
-}
-
-
-/* SMBus routines borrowed from VIA's Trident Driver */
-/* this works, so I am not going to touch it for now -- rgm */
-static unsigned char smbus_read_byte(unsigned char devAdr,
-				unsigned char bIndex)
-{
-	unsigned short i;
-	unsigned char  bData;
-	unsigned char  sts = 0;
-
-	/* clear host status */
-	outb(0xff, SMBUS_IO_BASE);
-
-	/* check SMBUS ready */
-	for ( i = 0; i < 0xFFFF; i++ )
-		if ( (inb(SMBUS_IO_BASE) & 0x01) == 0 )
-			break;
-
-	/* set host command */
-	outb(bIndex, SMBUS_IO_BASE+3);
-
-	/* set slave address */
-	outb((devAdr << 1) | 0x01, SMBUS_IO_BASE+4);
-
-	/* start */
-	outb(0x48, SMBUS_IO_BASE+2);
-
-	/* SMBUS Wait Ready */
-	for ( i = 0; i < 0xFFFF; i++ )
-		if ( ((sts = (inb(SMBUS_IO_BASE) & 0x1f)) & 0x01) == 0 )
-			break;
-
-	if ((sts & ~3) != 0) {
-		smbus_print_error(sts);
-		return 0;
-	}
-	bData=inb(SMBUS_IO_BASE+5);
-
-	return bData;
-
-}
-
-/* for reference, here is the fancier version which we will use at some
- * point
- */
-# if 0
-int smbus_read_byte(unsigned device, unsigned address, unsigned char *result)
-{
-	unsigned char host_status_register;
-	unsigned char byte;
-
-	reset();
-
-	smbus_wait_until_ready();
-
-	/* setup transaction */
-	/* disable interrupts */
-	outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);
-	/* set the device I'm talking too */
-	outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBXMITADD);
-	/* set the command/address... */
-	outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);
-	/* set up for a byte data read */
-	outb((inb(SMBUS_IO_BASE + SMBHSTCTL) & 0xE3) | (0x2 << 2),
-		SMBUS_IO_BASE + SMBHSTCTL);
-
-	/* clear any lingering errors, so the transaction will run */
-	outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
-
-	/* clear the data byte...*/
-	outb(0, SMBUS_IO_BASE + SMBHSTDAT0);
-
-	/* start the command */
-	outb((inb(SMBUS_IO_BASE + SMBHSTCTL) | 0x40),
-		SMBUS_IO_BASE + SMBHSTCTL);
-
-	/* poll for transaction completion */
-	smbus_wait_until_done();
-
-	host_status_register = inb(SMBUS_IO_BASE + SMBHSTSTAT);
-
-	/* Ignore the In Use Status... */
-	host_status_register &= ~(1 << 6);
-
-	/* read results of transaction */
-	byte = inb(SMBUS_IO_BASE + SMBHSTDAT0);
-	smbus_print_error(byte);
-
-	*result = byte;
-	return host_status_register != 0x02;
-}
-
-#endif
diff --git a/src/southbridge/via/vt8235/ide.c b/src/southbridge/via/vt8235/ide.c
deleted file mode 100644
index 176e70fea7..0000000000
--- a/src/southbridge/via/vt8235/ide.c
+++ /dev/null
@@ -1,113 +0,0 @@
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-#include <console/console.h>
-#include "chip.h"
-
-static void ide_init(struct device *dev)
-{
-	struct southbridge_via_vt8235_config *conf = dev->chip_info;
-	unsigned char enables;
-
-	printk(BIOS_INFO, "Enabling VIA IDE.\n");
-
-	/*if (!conf->enable_native_ide) { */
-		/*
-		 * Run the IDE controller in 'compatibility mode - i.e. don't
-		 * use PCI interrupts.  Using PCI ints confuses linux for some
-		 * reason.
-		 */
-		printk(BIOS_INFO, "%s: enabling compatibility IDE addresses\n",
-				__func__);
-		enables = pci_read_config8(dev, 0x42);
-		printk(BIOS_DEBUG, "enables in reg 0x42 0x%x\n", enables);
-		enables &= ~0xc0;		// compatibility mode
-		pci_write_config8(dev, 0x42, enables);
-		enables = pci_read_config8(dev, 0x42);
-		printk(BIOS_DEBUG, "enables in reg 0x42 read back as 0x%x\n",
-				enables);
-	/* } */
-
-	enables = pci_read_config8(dev, 0x40);
-	printk(BIOS_DEBUG, "enables in reg 0x40 0x%x\n", enables);
-	enables |= 3;
-	pci_write_config8(dev, 0x40, enables);
-	enables = pci_read_config8(dev, 0x40);
-	printk(BIOS_DEBUG, "enables in reg 0x40 read back as 0x%x\n", enables);
-
-	// Enable prefetch buffers
-	enables = pci_read_config8(dev, 0x41);
-	enables |= 0xf0;
-	pci_write_config8(dev, 0x41, enables);
-
-	// Lower thresholds (cause award does it)
-	enables = pci_read_config8(dev, 0x43);
-	enables &= ~0x0f;
-	enables |=  0x05;
-	pci_write_config8(dev, 0x43, enables);
-
-	// PIO read prefetch counter (cause award does it)
-	pci_write_config8(dev, 0x44, 0x18);
-
-	// Use memory read multiple
-	pci_write_config8(dev, 0x45, 0x1c);
-
-	// address decoding.
-	// we want "flexible", i.e. 1f0-1f7 etc. or native PCI
-	// kevinh@ispiri.com - the standard linux drivers seem ass slow when
-	// used in native mode - I've changed back to classic
-	enables = pci_read_config8(dev, 0x9);
-	printk(BIOS_DEBUG, "enables in reg 0x9 0x%x\n", enables);
-	// by the book, set the low-order nibble to 0xa.
-	if (conf->enable_native_ide) {
-		enables &= ~0xf;
-		// cf/cg silicon needs an 'f' here.
-		enables |= 0xf;
-	} else {
-		enables &= ~0x5;
-	}
-
-	pci_write_config8(dev, 0x9, enables);
-	enables = pci_read_config8(dev, 0x9);
-	printk(BIOS_DEBUG, "enables in reg 0x9 read back as 0x%x\n", enables);
-
-	// standard bios sets master bit.
-	enables = pci_read_config8(dev, 0x4);
-	printk(BIOS_DEBUG, "command in reg 0x4 0x%x\n", enables);
-	enables |= 7;
-
-	// No need for stepping - kevinh@ispiri.com
-	enables &= ~0x80;
-
-	pci_write_config8(dev, 0x4, enables);
-	enables = pci_read_config8(dev, 0x4);
-	printk(BIOS_DEBUG, "command in reg 0x4 reads back as 0x%x\n", enables);
-
-	if (!conf->enable_native_ide) {
-		// Use compatibility mode - per award bios
-		pci_write_config32(dev, 0x10, 0x0);
-		pci_write_config32(dev, 0x14, 0x0);
-		pci_write_config32(dev, 0x18, 0x0);
-		pci_write_config32(dev, 0x1c, 0x0);
-
-		// Force interrupts to use compat mode - just like Award bios
-		pci_write_config8(dev, 0x3d, 0x0);
-		pci_write_config8(dev, 0x3c, 0xff);
-	}
-}
-
-static struct device_operations ide_ops = {
-	.read_resources   = pci_dev_read_resources,
-	.set_resources    = pci_dev_set_resources,
-	.enable_resources = pci_dev_enable_resources,
-	.init             = ide_init,
-	.enable           = 0,
-	.ops_pci          = 0,
-};
-
-static const struct pci_driver northbridge_driver __pci_driver = {
-	.ops    = &ide_ops,
-	.vendor = PCI_VENDOR_ID_VIA,
-	.device = PCI_DEVICE_ID_VIA_82C586_1,
-};
diff --git a/src/southbridge/via/vt8235/lpc.c b/src/southbridge/via/vt8235/lpc.c
deleted file mode 100644
index e6aac65375..0000000000
--- a/src/southbridge/via/vt8235/lpc.c
+++ /dev/null
@@ -1,261 +0,0 @@
-#include <arch/io.h>
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-#include <pc80/mc146818rtc.h>
-#include <arch/ioapic.h>
-#include "chip.h"
-
-/* The epia-m is really short on interrupts available, so PCI interrupts A & D are ganged together and so are B & C.
-   This is how the Award bios sets it up too.
-   epia can be more generous as it does not need to reserve interrupts for cardbus devices, but if changed then
-   make sure that ACPI dsdt is changed to suit.
-
-	IRQ 0 = timer
-	IRQ 1 = keyboard
-	IRQ 2 = cascade
-	IRQ 3 = COM 2
-	IRQ 4 = COM 1
-	IRQ 5 = available for PCI interrupts
-	IRQ 6 = floppy or available for PCI if floppy controller disabled
-        IRQ 7 = LPT or available if LPT port disabled
-	IRQ 8 = rtc
-	IRQ 9 = available for PCI interrupts
-	IRQ 10 = cardbus slot or available for PCI if no cardbus (ie epia)
-	IRQ 11 = cardbus slot or available for PCI if no cardbus (ie epia)
-	IRQ 12 = PS2 mouse (hardwired to 12)
-	IRQ 13 = legacy FPU interrupt
-	IRQ 14 = IDE controller 1
-	IRQ 15 = IDE controller 2
-
-*/
-static const unsigned char pciIrqs[4] = { 5 , 9 , 9, 5 };
-
-static const unsigned char usbPins[4] =      { 'A','B','C','D'};
-static const unsigned char enetPins[4] =     { 'A','B','C','D'};
-static const unsigned char slotPins[4] =     { 'B','C','D','A'};
-static const unsigned char firewirePins[4] = { 'B','C','D','A'};
-static const unsigned char vt8235Pins[4] =   { 'A','B','C','D'};
-static const unsigned char vgaPins[4] =      { 'A','B','C','D'};
-static const unsigned char cbPins[4] =       { 'A','B','C','D'};
-static const unsigned char riserPins[4] =    { 'A','B','C','D'};
-
-
-static unsigned char *pin_to_irq(const unsigned char *pin)
-{
-	static unsigned char Irqs[4];
-	int i;
-	for (i = 0 ; i < 4 ; i++)
-		Irqs[i] = pciIrqs[ pin[i] - 'A' ];
-
-	return Irqs;
-}
-
-static void pci_routing_fixup(struct device *dev)
-{
-	printk(BIOS_INFO, "%s: dev is %p\n", __func__, dev);
-
-	/* set up PCI IRQ routing */
-	pci_write_config8(dev, 0x55, pciIrqs[0] << 4);
-	pci_write_config8(dev, 0x56, pciIrqs[1] | (pciIrqs[2] << 4) );
-	pci_write_config8(dev, 0x57, pciIrqs[3] << 4);
-
-
-	// firewire built into southbridge
-	printk(BIOS_INFO, "setting firewire\n");
-	pci_assign_irqs(0, 0x0d, pin_to_irq(firewirePins));
-
-	// Standard usb components
-	printk(BIOS_INFO, "setting usb\n");
-	pci_assign_irqs(0, 0x10, pin_to_irq(usbPins));
-
-	// VT8235 + sound hardware
-	printk(BIOS_INFO, "setting vt8235\n");
-	pci_assign_irqs(0, 0x11, pin_to_irq(vt8235Pins));
-
-	// Ethernet built into southbridge
-	printk(BIOS_INFO, "setting ethernet\n");
-	pci_assign_irqs(0, 0x12, pin_to_irq(enetPins));
-
-	// VGA
-	printk(BIOS_INFO, "setting vga\n");
-	pci_assign_irqs(1, 0x00, pin_to_irq(vgaPins));
-
-	// PCI slot
-	printk(BIOS_INFO, "setting pci slot\n");
-	pci_assign_irqs(0, 0x14, pin_to_irq(slotPins));
-
-	// Cardbus slot
-	printk(BIOS_INFO, "setting cardbus slot\n");
-	pci_assign_irqs(0, 0x0a, pin_to_irq(cbPins));
-
-	// Via 2 slot riser card 2nd slot
-	printk(BIOS_INFO, "setting riser slot\n");
-	pci_assign_irqs(0, 0x13, pin_to_irq(riserPins));
-
-	printk(BIOS_SPEW, "%s: DONE\n", __func__);
-}
-
-/*
- * Set up the power management capabilities directly into ACPI mode.  This
- * avoids having to handle any System Management Interrupts (SMI's) which I
- * can't figure out how to do !!!!
- */
-
-static void setup_pm(device_t dev)
-{
-	// Set gen config 0
-	pci_write_config8(dev, 0x80, 0x20);
-
-	// Set ACPI base address to IO 0x400
-	pci_write_config16(dev, 0x88, 0x0401);
-
-	// set ACPI irq to 5
-	pci_write_config8(dev, 0x82, 0x45);
-
-	// primary interrupt channel
-	pci_write_config16(dev, 0x84, 0x30f2);
-
-	// throttle / stop clock control
-	pci_write_config8(dev, 0x8d, 0x18);
-
-	pci_write_config8(dev, 0x93, 0x88);
-	pci_write_config8(dev, 0x94, 0xb0);
-	pci_write_config8(dev, 0x95, 0xc0);
-	pci_write_config8(dev, 0x98, 0);
-	pci_write_config8(dev, 0x99, 0xea);
-	pci_write_config8(dev, 0xe4, 0x14);
-	pci_write_config8(dev, 0xe5, 0x08);
-
-
-	// Enable ACPI access (and setup like award)
-	pci_write_config8(dev, 0x81, 0x84);
-
-	outw(0xffff, 0x400);
-	outw(0xffff, 0x420);
-	outw(0xffff, 0x428);
-	outl(0xffffffff, 0x430);
-
-	outw(0x0, 0x424);
-	outw(0x0, 0x42a);
-	outw(0x1, 0x42c);
-	outl(0x0, 0x434);
-	outl(0x01, 0x438);
-	outb(0x0, 0x442);
-	outl(0xffff7fff, 0x448);
-	outw(0x001, 0x404);
-}
-
-static void vt8235_init(struct device *dev)
-{
-	unsigned char enables;
-
-	printk(BIOS_DEBUG, "vt8235 init\n");
-
-	// enable the internal I/O decode
-	enables = pci_read_config8(dev, 0x6C);
-	enables |= 0x80;
-	pci_write_config8(dev, 0x6C, enables);
-
-	// Map 4MB of FLASH into the address space
-	pci_write_config8(dev, 0x41, 0x7f);
-
-	// Set bit 6 of 0x40, because Award does it (IO recovery time)
-	// IMPORTANT FIX - EISA 0x4d0 decoding must be on so that PCI
-	// interrupts can be properly marked as level triggered.
-	enables = pci_read_config8(dev, 0x40);
-	enables |= 0x45;
-	pci_write_config8(dev, 0x40, enables);
-
-	// Set 0x42 to 0xf0 to match Award bios
-	enables = pci_read_config8(dev, 0x42);
-	enables |= 0xf0;
-	pci_write_config8(dev, 0x42, enables);
-
-	/* Set 0x58 to 0x03 to match Award */
-	pci_write_config8(dev, 0x58, 0x03);
-
-	/* Set bit 3 of 0x4f to match award (use INIT# as cpu reset) */
-	enables = pci_read_config8(dev, 0x4f);
-	enables |= 0x08;
-	pci_write_config8(dev, 0x4f, enables);
-
-	// Set bit 3 of 0x4a, to match award (dummy pci request)
-	enables = pci_read_config8(dev, 0x4a);
-	enables |= 0x08;
-	pci_write_config8(dev, 0x4a, enables);
-
-	// Set bit 3 of 0x4f to match award (use INIT# as cpu reset)
-	enables = pci_read_config8(dev, 0x4f);
-	enables |= 0x08;
-	pci_write_config8(dev, 0x4f, enables);
-
-	// Set 0x58 to 0x03 to match Award
-	pci_write_config8(dev, 0x58, 0x03);
-
-
-	/* enable serial irq */
-	pci_write_config8(dev, 0x52, 0x9);
-
-	/* dma */
-	pci_write_config8(dev, 0x53, 0x00);
-
-	// Power management setup
-	setup_pm(dev);
-
-	/* set up isa bus -- i/o recovery time, rom write enable, extend-ale */
-	pci_write_config8(dev, 0x40, 0x54);
-
-	// Start the rtc
-	cmos_init(0);
-}
-
-/* total kludge to get lxb to call our children's set/enable functions - these are not called unless this
-   device has a resource to set - so set a dummy one */
-static void vt8235_read_resources(device_t dev)
-{
-	struct resource *res;
-
-	pci_dev_read_resources(dev);
-
-	res = new_resource(dev, 1);
-	res->base = 0x0UL;
-	res->size = 0x1000UL;
-	res->limit = 0xffffUL;
-	res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
-
-	res = new_resource(dev, 3); /* IOAPIC */
-	res->base = IO_APIC_ADDR;
-	res->size = 0x00001000;
-	res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
-}
-
-static void vt8235_set_resources(device_t dev)
-{
-	//struct resource *resource;
-	//resource = find_resource(dev,1);
-	//resource->flags |= IORESOURCE_STORED;
-	pci_dev_set_resources(dev);
-}
-
-static void southbridge_init(struct device *dev)
-{
-	vt8235_init(dev);
-	pci_routing_fixup(dev);
-}
-
-static struct device_operations vt8235_lpc_ops = {
-	.read_resources   = vt8235_read_resources,
-	.set_resources    = vt8235_set_resources,
-	.enable_resources = pci_dev_enable_resources,
-	.init             = southbridge_init,
-	.scan_bus         = scan_static_bus,
-};
-
-static const struct pci_driver lpc_driver __pci_driver = {
-	.ops    = &vt8235_lpc_ops,
-	.vendor = PCI_VENDOR_ID_VIA,
-	.device = PCI_DEVICE_ID_VIA_8235,
-};
diff --git a/src/southbridge/via/vt8235/nic.c b/src/southbridge/via/vt8235/nic.c
deleted file mode 100644
index 71f169c055..0000000000
--- a/src/southbridge/via/vt8235/nic.c
+++ /dev/null
@@ -1,36 +0,0 @@
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-
-/*
- * Enable the ethernet device and turn off stepping (because it is integrated
- * inside the southbridge)
- */
-static void nic_init(struct device *dev)
-{
-	uint8_t	byte;
-
-	printk(BIOS_DEBUG, "Configuring VIA Rhine LAN\n");
-
-	/* We don't need stepping - though the device supports it */
-	byte = pci_read_config8(dev, PCI_COMMAND);
-	byte &= ~PCI_COMMAND_WAIT;
-	pci_write_config8(dev, PCI_COMMAND, byte);
-}
-
-static struct device_operations nic_ops = {
-	.read_resources   = pci_dev_read_resources,
-	.set_resources    = pci_dev_set_resources,
-	.enable_resources = pci_dev_enable_resources,
-	.init             = nic_init,
-	.enable           = 0,
-	.ops_pci          = 0,
-};
-
-static const struct pci_driver northbridge_driver __pci_driver = {
-	.ops    = &nic_ops,
-	.vendor = PCI_VENDOR_ID_VIA,
-	.device = PCI_DEVICE_ID_VIA_8233_7,
-};
diff --git a/src/southbridge/via/vt8235/usb.c b/src/southbridge/via/vt8235/usb.c
deleted file mode 100644
index d684968a31..0000000000
--- a/src/southbridge/via/vt8235/usb.c
+++ /dev/null
@@ -1,43 +0,0 @@
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-
-/* really nothing to do here, both usb 1.1 & 2.0 are normal PCI devices and so get resources allocated
-   properly. They are part of the southbridge and are enabled in the chip enable function for the southbridge */
-
-static void usb_init(struct device *dev)
-{
-	printk(BIOS_DEBUG, "Configuring VIA USB 1.1\n");
-
-	/* pci_write_config8(dev, 0x04, 0x07); */
-
-	/*
-	 * To disable; though do we need to do this?
-    		pci_write_config8(dev1, 0x3c, 0x00);
-    		pci_write_config8(dev1, 0x04, 0x00);
-
-	   Also, on the root dev, for enable:
-	   	regval = pci_read_config8(dev0, 0x50);
-		regval &= ~(0x36);
-		pci_write_config8(dev0, 0x50, regval);
-
-		(regval |= 0x36; for disable)
-	 */
-}
-
-static struct device_operations usb_ops = {
-	.read_resources   = pci_dev_read_resources,
-	.set_resources    = pci_dev_set_resources,
-	.enable_resources = pci_dev_enable_resources,
-	.init             = usb_init,
-	.enable           = 0,
-	.ops_pci          = 0,
-};
-
-static const struct pci_driver northbridge_driver __pci_driver = {
-	.ops    = &usb_ops,
-	.vendor = PCI_VENDOR_ID_VIA,
-	.device = PCI_DEVICE_ID_VIA_82C586_2,
-};
diff --git a/src/southbridge/via/vt8235/vt8235.c b/src/southbridge/via/vt8235/vt8235.c
deleted file mode 100644
index 0f37be2aee..0000000000
--- a/src/southbridge/via/vt8235/vt8235.c
+++ /dev/null
@@ -1,89 +0,0 @@
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-#include <pc80/keyboard.h>
-#include <pc80/i8259.h>
-#include "chip.h"
-
-static void keyboard_on(struct device *dev)
-{
-	u8 regval;
-
-	regval = pci_read_config8(dev, 0x51);
-	regval |= 0x05;
-	regval &= 0xfd;
-	pci_write_config8(dev, 0x51, regval);
-
-	pc_keyboard_init();
-}
-
-#ifdef UNUSED_CODE
-void dump_south(device_t dev0)
-{
-	int i,j;
-
-	for(i = 0; i < 256; i += 16) {
-		printk(BIOS_DEBUG, "0x%x: ", i);
-		for(j = 0; j < 16; j++) {
-			printk(BIOS_DEBUG, "%02x ", pci_read_config8(dev0, i+j));
-		}
-		printk(BIOS_DEBUG, "\n");
-	}
-}
-
-void set_led(void)
-{
-	// set power led to steady now that coreboot has virtually done its job
-	device_t dev;
-	dev = dev_find_device(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8235, 0);
-	pci_write_config8(dev, 0x94, 0xb0);
-}
-#endif
-
-static void vt8235_enable(struct device *dev)
-{
-	u8 regval;
-	u16 vendor,model;
-
-	vendor = pci_read_config16(dev,0);
-	model = pci_read_config16(dev,0x2);
-
-	printk(BIOS_DEBUG, "In vt8235_enable %04x %04x.\n",vendor,model);
-
-	/* If this is not the southbridge itself just return.
-	 * This is necessary because USB devices are slot 10, whereas this
-	 * device is slot 11 therefore usb devices get called first during
-	 * the bus scan. We don't want to wait until we could do dev->init
-	 * because that's too late.
-	 */
-
-	if( (vendor != PCI_VENDOR_ID_VIA) || (model != PCI_DEVICE_ID_VIA_8235))
-		return;
-
-	printk(BIOS_DEBUG, "Initialising Devices\n");
-
-	/* make sure interrupt controller is configured before keyboard init */
-	setup_i8259();
-
-	/* enable RTC and ethernet */
-	regval = pci_read_config8(dev, 0x51);
-	regval |= 0x18;
-	pci_write_config8(dev, 0x51, regval);
-
-	/* turn on keyboard */
-	keyboard_on(dev);
-
-	/* enable USB 1.1 & USB 2.0 - redundant really since we've
-	 * already been there - see note above
-	 */
-   	regval = pci_read_config8(dev, 0x50);
-	regval &= ~(0x36);
-	pci_write_config8(dev, 0x50, regval);
-}
-
-struct chip_operations southbridge_via_vt8235_ops = {
-	CHIP_NAME("VIA VT8235 Southbridge")
-	.enable_dev = vt8235_enable,
-};
diff --git a/src/southbridge/via/vt8237r/early_serial.c b/src/southbridge/via/vt8237r/early_serial.c
new file mode 100644
index 0000000000..9143f4690a
--- /dev/null
+++ b/src/southbridge/via/vt8237r/early_serial.c
@@ -0,0 +1,77 @@
+/*
+ * Enable the serial devices on the VIA
+ */
+
+
+/* The base address is 0x15c, 0x2e, depending on config bytes */
+
+#define SIO_BASE 0x3f0
+#define SIO_DATA  SIO_BASE+1
+
+static void vt8237r_writepnpaddr(uint8_t val)
+{
+	outb(val, 0x2e);
+	outb(val, 0xeb);
+}
+
+static void vt8237r_writepnpdata(uint8_t val)
+{
+	outb(val, 0x2f);
+	outb(val, 0xeb);
+}
+
+
+static void vt8237r_writesiobyte(uint16_t reg, uint8_t val)
+{
+	outb(val, reg);
+}
+
+static void vt8237r_writesioword(uint16_t reg, uint16_t val)
+{
+	outw(val, reg);
+}
+
+
+/* regs we use: 85, and the southbridge devfn is defined by the
+   mainboard
+ */
+
+static void enable_vt8237r_serial(void)
+{
+	// turn on pnp
+	vt8237r_writepnpaddr(0x87);
+	vt8237r_writepnpaddr(0x87);
+	// now go ahead and set up com1.
+	// set address
+	vt8237r_writepnpaddr(0x7);
+	vt8237r_writepnpdata(0x2);
+	// enable serial out
+	vt8237r_writepnpaddr(0x30);
+	vt8237r_writepnpdata(0x1);
+	// serial port 1 base address (FEh)
+	vt8237r_writepnpaddr(0x60);
+	vt8237r_writepnpdata(0xfe);
+	// serial port 1 IRQ (04h)
+	vt8237r_writepnpaddr(0x70);
+	vt8237r_writepnpdata(0x4);
+	// serial port 1 control
+	vt8237r_writepnpaddr(0xf0);
+	vt8237r_writepnpdata(0x2);
+	// turn of pnp
+	vt8237r_writepnpaddr(0xaa);
+
+	// set up reg to set baud rate.
+	vt8237r_writesiobyte(0x3fb, 0x80);
+	// Set 115 kb
+	vt8237r_writesioword(0x3f8, 1);
+	// Set 9.6 kb
+	//	WRITESIOWORD(0x3f8, 12)
+	// now set no parity, one stop, 8 bits
+	vt8237r_writesiobyte(0x3fb, 3);
+	// now turn on RTS, DRT
+	vt8237r_writesiobyte(0x3fc, 3);
+	// Enable interrupts
+	vt8237r_writesiobyte(0x3f9, 0xf);
+	// should be done. Dump a char for fun.
+	vt8237r_writesiobyte(0x3f8, 48);
+}