summaryrefslogtreecommitdiff
path: root/src/southbridge
diff options
context:
space:
mode:
authorStefan Reinauer <stepan@coresystems.de>2010-04-09 15:29:13 +0000
committerStefan Reinauer <stepan@openbios.org>2010-04-09 15:29:13 +0000
commit2c0db453b69e025049bc114c21fdc294648eefdf (patch)
tree24917a521a8271654881015b1e6e707bf7441d08 /src/southbridge
parentd4f53738e678f99bd12068b2e2b2ecae9fc046b0 (diff)
downloadcoreboot-2c0db453b69e025049bc114c21fdc294648eefdf.tar.xz
fix the broken nvidia chipset boards,
remove more warnings. Signed-off-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5397 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge')
-rw-r--r--src/southbridge/broadcom/bcm5785/bcm5785_early_setup.c1
-rw-r--r--src/southbridge/intel/i82801ax/i82801ax_smbus.h15
2 files changed, 6 insertions, 10 deletions
diff --git a/src/southbridge/broadcom/bcm5785/bcm5785_early_setup.c b/src/southbridge/broadcom/bcm5785/bcm5785_early_setup.c
index 25ad7baf32..fd2f3ed114 100644
--- a/src/southbridge/broadcom/bcm5785/bcm5785_early_setup.c
+++ b/src/southbridge/broadcom/bcm5785/bcm5785_early_setup.c
@@ -3,6 +3,7 @@
* by yinghai.lu@amd.com
*/
+#include <reset.h>
static void bcm5785_enable_rom(void)
{
unsigned char byte;
diff --git a/src/southbridge/intel/i82801ax/i82801ax_smbus.h b/src/southbridge/intel/i82801ax/i82801ax_smbus.h
index e4ec70bc5f..06d987721f 100644
--- a/src/southbridge/intel/i82801ax/i82801ax_smbus.h
+++ b/src/southbridge/intel/i82801ax/i82801ax_smbus.h
@@ -110,24 +110,21 @@ static int do_smbus_read_byte(unsigned device, unsigned address)
return byte;
}
-/* This function is neither used nor tested by me (Corey Osgood), the author
-(Yinghai) probably tested/used it on i82801er */
static int do_smbus_write_block(unsigned device, unsigned length, unsigned cmd,
unsigned data1, unsigned data2)
{
-#warning "do_smbus_write_block is commented out"
- print_err("Untested smbus_write_block called\n");
-#if 0
unsigned char global_control_register;
unsigned char global_status_register;
unsigned char byte;
unsigned char stat;
int i;
+ print_err("Untested smbus_write_block called\n");
+
/* Clear the PM timeout flags, SECOND_TO_STS */
- outw(inw(0x0400 + 0x66), 0x0400 + 0x66);
+ outw(inw(PMBASE_ADDR + 0x66), PMBASE_ADDR + 0x66);
- if (smbus_wait_until_ready(SMBUS_IO_BASE) < 0) {
+ if (smbus_wait_until_ready() < 0) {
return -2;
}
@@ -159,9 +156,8 @@ static int do_smbus_write_block(unsigned device, unsigned length, unsigned cmd,
SMBUS_IO_BASE + SMBHSTCTL);
for (i = 0; i < length; i++) {
-
/* Poll for transaction completion */
- if (smbus_wait_until_blk_done(SMBUS_IO_BASE) < 0) {
+ if (smbus_wait_until_blk_done() < 0) {
return -3;
}
@@ -179,5 +175,4 @@ static int do_smbus_write_block(unsigned device, unsigned length, unsigned cmd,
print_debug("SMBUS Block complete\n");
return 0;
-#endif
}