summaryrefslogtreecommitdiff
path: root/src/southbridge
diff options
context:
space:
mode:
authorPatrick Rudolph <patrick.rudolph@9elements.com>2019-07-19 16:31:37 +0200
committerPatrick Rudolph <siro@das-labor.org>2020-05-28 06:26:32 +0000
commit78e8db1eebaf4e90c0de2b38a0cc8832057766a7 (patch)
treee1c5345448a0286f4bad695fe3ce0ea57e16c5af /src/southbridge
parenta121f953937eb718cc579ce2c428937d00a91287 (diff)
downloadcoreboot-78e8db1eebaf4e90c0de2b38a0cc8832057766a7.tar.xz
sb/intel/{bd82x6x|ibexpeak}: Clear flush_* in FADT
Both fields are ignored if WBINVD is set, which is true for all processors since i486. Change-Id: Ibad56046e2c1b8595dc31e5861b9fd1fd7d2d6f3 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Christian Walter <christian.walter@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34453 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/southbridge')
-rw-r--r--src/southbridge/intel/bd82x6x/lpc.c6
-rw-r--r--src/southbridge/intel/ibexpeak/lpc.c6
2 files changed, 6 insertions, 6 deletions
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 987db360e2..55e2573eff 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -726,12 +726,12 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
}
fadt->p_lvl2_lat = c2_latency;
fadt->p_lvl3_lat = 87;
- fadt->flush_size = 1024;
- fadt->flush_stride = 16;
+ /* flush_* is ignored if ACPI_FADT_WBINVD is set */
+ fadt->flush_size = 0;
+ fadt->flush_stride = 0;
/* P_CNT not supported */
fadt->duty_offset = 0;
fadt->duty_width = 0;
-
fadt->day_alrm = 0xd;
fadt->mon_alrm = 0x00;
fadt->century = 0x00;
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c
index 0d15b5d8fa..54b2621bca 100644
--- a/src/southbridge/intel/ibexpeak/lpc.c
+++ b/src/southbridge/intel/ibexpeak/lpc.c
@@ -620,12 +620,12 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
}
fadt->p_lvl2_lat = c2_latency;
fadt->p_lvl3_lat = 87;
- fadt->flush_size = 1024;
- fadt->flush_stride = 16;
+ /* flush_* is ignored if ACPI_FADT_WBINVD is set */
+ fadt->flush_size = 0;
+ fadt->flush_stride = 0;
/* P_CNT not supported */
fadt->duty_offset = 0;
fadt->duty_width = 0;
-
fadt->day_alrm = 0xd;
fadt->mon_alrm = 0x00;
fadt->century = 0x32;