summaryrefslogtreecommitdiff
path: root/src/southbridge
diff options
context:
space:
mode:
authorKeith Hui <buurin@gmail.com>2020-05-15 16:14:26 -0400
committerPatrick Georgi <pgeorgi@google.com>2020-07-06 06:23:44 +0000
commit562279e6caf6609c599ec97f65947c0e94a1085f (patch)
treefab94f069878ecc5c820574aba746c44c45887c5 /src/southbridge
parentc73ad35e39b5b9136f59d646c43f28366b7271c8 (diff)
downloadcoreboot-562279e6caf6609c599ec97f65947c0e94a1085f.tar.xz
sb/intel/i82371eb: Don't fill \_SB.PCI0.MBRS
Only two mainboard groups use this southbridge: emulation/qemu-i440fx: Nothing creates or consumes this ACPI path. asus/p2b: It only fills the (mostly static) PIIX4E PM/SMBus I/O resources, which are being declared in DSDT. It is not doing anything useful and causes ACPI errors in Linux kernel[1][2], so it has to stop. [1] https://review.coreboot.org/c/coreboot/+/38601 [2] https://review.coreboot.org/c/coreboot/+/38304 Change-Id: I770047610e02c08191613b57c989b3bc1d464684 Signed-off-by: Keith Hui <buurin@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41457 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/southbridge')
-rw-r--r--src/southbridge/intel/i82371eb/isa.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c
index ae35d90b2c..237ed361fd 100644
--- a/src/southbridge/intel/i82371eb/isa.c
+++ b/src/southbridge/intel/i82371eb/isa.c
@@ -102,21 +102,13 @@ static void sb_read_resources(struct device *dev)
#endif
}
-#if CONFIG(HAVE_ACPI_TABLES)
-static void southbridge_acpi_fill_ssdt_generator(const struct device *device)
-{
- acpigen_write_mainboard_resources("\\_SB.PCI0.MBRS", "_CRS");
- generate_cpu_entries(device);
-}
-#endif
-
static const struct device_operations isa_ops = {
.read_resources = sb_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.write_acpi_tables = acpi_write_hpet,
- .acpi_fill_ssdt = southbridge_acpi_fill_ssdt_generator,
+ .acpi_fill_ssdt = generate_cpu_entries,
#endif
.init = isa_init,
.scan_bus = scan_static_bus,