summaryrefslogtreecommitdiff
path: root/src/southbridge
diff options
context:
space:
mode:
authorPatrick Georgi <patrick@georgi-clan.de>2010-11-20 10:31:00 +0000
committerPatrick Georgi <patrick.georgi@coresystems.de>2010-11-20 10:31:00 +0000
commit9bd9a90d6a0a47ede6286e2c5599ae7335e4b96a (patch)
tree325b7b6abc1d4514d52ad1f726d9be4fa00d0454 /src/southbridge
parent622824cadbbbe003bc3e8c97694d2cf6bae0de9b (diff)
downloadcoreboot-9bd9a90d6a0a47ede6286e2c5599ae7335e4b96a.tar.xz
Unify DIMM SPD addressing. For Geode, change the
addressing scheme to match the rest of the tree (0x50 instead of 0xa0). abuild tested. Signed-off-by: Patrick Georgi <patrick@georgi-clan.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6099 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge')
-rw-r--r--src/southbridge/amd/cs5536/cs5536_early_smbus.c4
-rw-r--r--src/southbridge/via/vt8231/vt8231_early_smbus.c1
-rw-r--r--src/southbridge/via/vt8235/vt8235_early_smbus.c1
3 files changed, 2 insertions, 4 deletions
diff --git a/src/southbridge/amd/cs5536/cs5536_early_smbus.c b/src/southbridge/amd/cs5536/cs5536_early_smbus.c
index ce8e690567..5cb815d250 100644
--- a/src/southbridge/amd/cs5536/cs5536_early_smbus.c
+++ b/src/southbridge/amd/cs5536/cs5536_early_smbus.c
@@ -165,7 +165,7 @@ static unsigned char do_smbus_read_byte(unsigned smbus_io_base,
goto err;
}
- if ((smbus_send_slave_address(smbus_io_base, device))) {
+ if ((smbus_send_slave_address(smbus_io_base, device << 1))) {
error = 3;
goto err;
}
@@ -182,7 +182,7 @@ static unsigned char do_smbus_read_byte(unsigned smbus_io_base,
goto err;
}
- if ((smbus_send_slave_address(smbus_io_base, device | 0x01))) {
+ if ((smbus_send_slave_address(smbus_io_base, (device << 1) | 0x01))) {
error = 6;
goto err;
}
diff --git a/src/southbridge/via/vt8231/vt8231_early_smbus.c b/src/southbridge/via/vt8231/vt8231_early_smbus.c
index 8ba72a387b..7bf1267b75 100644
--- a/src/southbridge/via/vt8231/vt8231_early_smbus.c
+++ b/src/southbridge/via/vt8231/vt8231_early_smbus.c
@@ -16,7 +16,6 @@
/* Define register settings */
#define HOST_RESET 0xff
-#define DIMM_BASE 0xa0 // 1010000 is base for DIMM in SMBus
#define READ_CMD 0x01 // 1 in the 0 bit of SMBHSTADD states to READ
diff --git a/src/southbridge/via/vt8235/vt8235_early_smbus.c b/src/southbridge/via/vt8235/vt8235_early_smbus.c
index 1876461a3d..7b9d55dced 100644
--- a/src/southbridge/via/vt8235/vt8235_early_smbus.c
+++ b/src/southbridge/via/vt8235/vt8235_early_smbus.c
@@ -16,7 +16,6 @@
/* Define register settings */
#define HOST_RESET 0xff
-#define DIMM_BASE 0xa0 // 1010000 is base for DIMM in SMBus
#define READ_CMD 0x01 // 1 in the 0 bit of SMBHSTADD states to READ