diff options
| author | Nico Huber <nico.huber@secunet.com> | 2013-07-01 16:29:16 +0200 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2013-07-03 17:58:20 +0200 |
| commit | dd94fa93b403a73cc7d7b282eb6cefeb27512d13 (patch) | |
| tree | 04177e49f21a1bfb9c2278ccd8fb2374371c0d90 /src/superio/acpi/pnp_uart.asl | |
| parent | 1c81128dcd3a723f75d554b0a8d87101d7dd3663 (diff) | |
| download | coreboot-dd94fa93b403a73cc7d7b282eb6cefeb27512d13.tar.xz | |
winbond/w83627dhg: Fix logical device power down in ACPI
The W83627DHG has some power managements bits to power down individual
logical devices. These are called `* Power Down`. Counterintuitively and
in contrast to `Immediate Power Down` (bit to power down the whole chip),
these bits are set when the respective logical device is powered.
Unfortunately, our ACPI code set them wrong which led to disabled
devices after a S3 suspend/resume. Adding an option how to set the PM
bits and setting them to zero for the W83627DHG, corrects it.
Tested with kontron/ktqm77.
Change-Id: I8a472d480d4277721bd17c9f7c2ce44fa84e8ae2
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: http://review.coreboot.org/3590
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/superio/acpi/pnp_uart.asl')
| -rw-r--r-- | src/superio/acpi/pnp_uart.asl | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl index c826106ea8..8ddecbfe61 100644 --- a/src/superio/acpi/pnp_uart.asl +++ b/src/superio/acpi/pnp_uart.asl @@ -32,7 +32,9 @@ * name (DDN) of this uart (e.g. "COM1", optional) * SUPERIO_UART_PM_REG Identifier of a 1-bit register to power down * the UART (optional) - * SUPERIO_UART_PM_LDN The logical device number to access the PM_REG + * SUPERIO_UART_PM_VAL The value for SUPERIO_UART_PM_REG to power the logical + * device down (required if SUPERIO_UART_PM_REG is defined) + * SUPERIO_UART_PM_LDN The logical device number to access the PM_REG * bit (required if SUPERIO_UART_PM_REG is defined) */ @@ -65,15 +67,15 @@ Device (SUPERIO_ID(SER, SUPERIO_UART_LDN)) { #ifdef SUPERIO_UART_PM_REG Method (_PSC) { - PNP_GENERIC_PSC(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_LDN) + PNP_GENERIC_PSC(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_VAL, SUPERIO_UART_PM_LDN) } Method (_PS0) { - PNP_GENERIC_PS0(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_LDN) + PNP_GENERIC_PS0(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_VAL, SUPERIO_UART_PM_LDN) } Method (_PS1) { - PNP_GENERIC_PS1(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_LDN) + PNP_GENERIC_PS1(SUPERIO_UART_PM_REG, SUPERIO_UART_PM_VAL, SUPERIO_UART_PM_LDN) } #else Method (_PSC) { |