diff options
| author | Keith Hui <buurin@gmail.com> | 2017-10-16 17:14:25 -0400 |
|---|---|---|
| committer | Marc Jones <marc@marcjonesconsulting.com> | 2017-10-25 14:32:39 +0000 |
| commit | 74d8ed0cb8c659ec65b509bc32882e194168a891 (patch) | |
| tree | d1ed3a13bb79f93a71668f3db9ff698668336940 /src/superio/acpi | |
| parent | b8d66bb6fdb86f4dd6f02fd7e2f9a90717cceafe (diff) | |
| download | coreboot-74d8ed0cb8c659ec65b509bc32882e194168a891.tar.xz | |
superio/acpi/pnp.asl: Fix PNP_READ_DMA/PNP_WRITE_DMA macros
These macros, broken since day one, should CreateByteField instead
of CreateWordField. Without the fix, any ASLs that try to use it
will fail to compile with a "ResourceTag smaller than Field"
warning.
Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/22066
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/superio/acpi')
| -rw-r--r-- | src/superio/acpi/pnp.asl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/superio/acpi/pnp.asl b/src/superio/acpi/pnp.asl index 114dfe993d..c5aba6dadf 100644 --- a/src/superio/acpi/pnp.asl +++ b/src/superio/acpi/pnp.asl @@ -124,7 +124,7 @@ ShiftLeft (One, IRQ_FROM, IRQ_TAG##W) #define PNP_READ_DMA(DMA_FROM, RESOURCE_TEMPLATE, DMA_TAG) \ - CreateWordField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\ + CreateByteField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\ ShiftLeft (One, DMA_FROM, DMA_TAG##W) #define PNP_WRITE_IO(IO_TO, RESOURCE, IO_TAG) \ @@ -137,7 +137,7 @@ Subtract (FindSetLeftBit (IRQ_TAG##W), 1, IRQ_TO) #define PNP_WRITE_DMA(DMA_TO, RESOURCE, DMA_TAG) \ - CreateWordField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\ + CreateByteField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\ Subtract (FindSetLeftBit (DMA_TAG##W), 1, DMA_TO) #endif |