summaryrefslogtreecommitdiff
path: root/src/superio/fintek/f71859
diff options
context:
space:
mode:
authorUwe Hermann <uwe@hermann-uwe.de>2010-11-05 00:07:13 +0000
committerUwe Hermann <uwe@hermann-uwe.de>2010-11-05 00:07:13 +0000
commit7d3418849de907b82e3a5cca9969d261553f61a0 (patch)
tree3d3be4679f4e77d29f213a203f7150dc1586e92c /src/superio/fintek/f71859
parente4870474b9026ad6b2ccabe59a8623e28722007f (diff)
downloadcoreboot-7d3418849de907b82e3a5cca9969d261553f61a0.tar.xz
Fintek and Intel i3100 Super I/O cleanups.
- Drop commented out "config chip.h" and a duplicate link to a datasheet. - F71805F -> F71805F/FG, to mention all variants. - Use u8/u16/ etc. everywhere. - Add a missing (C) line. - Fix up a bunch of pnp_dev_info[] structs according to the datasheets. - Fintek F71889: Drop res1/PNP_IO1 from KBC, there's no 0x62/0x63 register pair on this Super I/O. - Fintek F71863FG: This Super I/O _does_ have a keyboard/mouse LDN, add the respective code in superio.c. Also: Add missing LDNs to f71863fg.h. - i3100: Add some more comments and datasheet infos. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6020 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/fintek/f71859')
-rwxr-xr-xsrc/superio/fintek/f71859/Makefile.inc4
-rwxr-xr-xsrc/superio/fintek/f71859/f71859_early_serial.c8
-rwxr-xr-xsrc/superio/fintek/f71859/superio.c1
3 files changed, 7 insertions, 6 deletions
diff --git a/src/superio/fintek/f71859/Makefile.inc b/src/superio/fintek/f71859/Makefile.inc
index 1e1205db77..0c71867256 100755
--- a/src/superio/fintek/f71859/Makefile.inc
+++ b/src/superio/fintek/f71859/Makefile.inc
@@ -1,6 +1,8 @@
##
## This file is part of the coreboot project.
##
+## Copyright (C) 2010 Marc Jones <marcj303@gmail.com>
+##
## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by
## the Free Software Foundation; either version 2 of the License, or
@@ -16,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
##
-#config chip.h
ramstage-$(CONFIG_SUPERIO_FINTEK_F71859) += superio.c
+
diff --git a/src/superio/fintek/f71859/f71859_early_serial.c b/src/superio/fintek/f71859/f71859_early_serial.c
index 07d62088df..c27b17937e 100755
--- a/src/superio/fintek/f71859/f71859_early_serial.c
+++ b/src/superio/fintek/f71859/f71859_early_serial.c
@@ -23,19 +23,19 @@
#include <arch/romcc_io.h>
#include "f71859.h"
-static inline void pnp_enter_conf_state(device_t dev)
+static void pnp_enter_conf_state(device_t dev)
{
- unsigned int port = dev >> 8;
+ u16 port = dev >> 8;
outb(0x87, port);
}
static void pnp_exit_conf_state(device_t dev)
{
- unsigned int port = dev >> 8;
+ u16 port = dev >> 8;
outb(0xaa, port);
}
-static void f71859_enable_serial(device_t dev, unsigned int iobase)
+static void f71859_enable_serial(device_t dev, u16 iobase)
{
pnp_enter_conf_state(dev);
pnp_set_logical_device(dev);
diff --git a/src/superio/fintek/f71859/superio.c b/src/superio/fintek/f71859/superio.c
index caf6f12e4d..c6fe6169f6 100755
--- a/src/superio/fintek/f71859/superio.c
+++ b/src/superio/fintek/f71859/superio.c
@@ -19,7 +19,6 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-
#include <arch/io.h>
#include <device/device.h>
#include <device/pnp.h>