diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2015-01-04 04:25:38 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2015-01-04 13:47:35 +0100 |
| commit | e64f5b1bcd589b4ac517909f5332f9926ab7d642 (patch) | |
| tree | 1c8d4df7ac235650bde6a6ce1c04327a715dad05 /src/superio/intel/i3100 | |
| parent | 24fb03e767d3c81184e4a6ea80a31f62b4edac36 (diff) | |
| download | coreboot-e64f5b1bcd589b4ac517909f5332f9926ab7d642.tar.xz | |
superio/intel/i3100: Use link-time symbol over .c includes
Change-Id: I83db9b189e672b0e1f25bc42b73639c375bea3e5
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8054
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/superio/intel/i3100')
| -rw-r--r-- | src/superio/intel/i3100/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/superio/intel/i3100/early_serial.c | 6 | ||||
| -rw-r--r-- | src/superio/intel/i3100/i3100.h | 12 |
3 files changed, 14 insertions, 5 deletions
diff --git a/src/superio/intel/i3100/Makefile.inc b/src/superio/intel/i3100/Makefile.inc index dedd4198e5..22843982a8 100644 --- a/src/superio/intel/i3100/Makefile.inc +++ b/src/superio/intel/i3100/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_INTEL_I3100) += early_serial.c ramstage-$(CONFIG_SUPERIO_INTEL_I3100) += superio.c diff --git a/src/superio/intel/i3100/early_serial.c b/src/superio/intel/i3100/early_serial.c index 96bb5501cf..0a3dc1128f 100644 --- a/src/superio/intel/i3100/early_serial.c +++ b/src/superio/intel/i3100/early_serial.c @@ -19,6 +19,8 @@ */ #include <arch/io.h> +#include <device/pnp.h> +#include <stdint.h> #include "i3100.h" static void pnp_enter_ext_func_mode(pnp_devfn_t dev) @@ -38,14 +40,14 @@ static void pnp_exit_ext_func_mode(pnp_devfn_t dev) } /* Enable device interrupts, set UART_CLK predivide. */ -static void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide) +void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide) { pnp_enter_ext_func_mode(dev); pnp_write_config(dev, I3100_SIW_CONFIGURATION, (predivide << 2) | 1); pnp_exit_ext_func_mode(dev); } -static void i3100_enable_serial(pnp_devfn_t dev, u16 iobase) +void i3100_enable_serial(pnp_devfn_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/intel/i3100/i3100.h b/src/superio/intel/i3100/i3100.h index 4b8bf27801..3f51a484ed 100644 --- a/src/superio/intel/i3100/i3100.h +++ b/src/superio/intel/i3100/i3100.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_INTEL_I3100_I3100_H -#define SUPERIO_INTEL_I3100_I3100_H +#ifndef SUPERIO_INTEL_I3100_H +#define SUPERIO_INTEL_I3100_H /* * Datasheet: @@ -61,4 +61,10 @@ #define I3100_UART_CLK_PREDIVIDE_8 0x01 #define I3100_UART_CLK_PREDIVIDE_26 0x02 -#endif +#include <arch/io.h> +#include <stdint.h> + +void i3100_configure_uart_clk(pnp_devfn_t dev, u8 predivide); +void i3100_enable_serial(pnp_devfn_t dev, u16 iobase); + +#endif /* SUPERIO_INTEL_I3100_H */ |